> On April 12, 2013, 2:25 a.m., Mohammad Islam wrote: > > trunk/client/pom.xml, line 65 > > <https://reviews.apache.org/r/9622/diff/5/?file=280093#file280093line65> > > > > so all types of client will need these jars. For example , CLI. will it > > need those jars to run? Or it is only for JMS client.
CLI will not need this jars. But only users who are using the Java API will require this jars. > On April 12, 2013, 2:25 a.m., Mohammad Islam wrote: > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java, > > line 48 > > <https://reviews.apache.org/r/9622/diff/5/?file=280095#file280095line48> > > > > what is this file? any doc or example there for user? This file is a client side configuration file which can have the deserialization information. In the initial releases, we will not bundle this property file and use the default JSONDeserializer. But in future, this configuration file can be used to specify a deserializer if the default is not used. We are planning to have a separate patch just for documentation. There we will provide an example too about using the API. > On April 12, 2013, 2:25 a.m., Mohammad Islam wrote: > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java, > > line 63 > > <https://reviews.apache.org/r/9622/diff/5/?file=280095#file280095line63> > > > > is this a correct exception? I think caller can't catch it. (Not so > > important) Got a similar comment from Ryota. Converted from unchecked to checked exception so caller are forced to handle. Its already part of new diff > On April 12, 2013, 2:25 a.m., Mohammad Islam wrote: > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java, > > line 61 > > <https://reviews.apache.org/r/9622/diff/5/?file=280096#file280096line61> > > > > Wandering how other things such as missing dep will be populated. getDeserializedObject() will take care of deserailzing the msg body this method is to only set the header properties back in the object. > On April 12, 2013, 2:25 a.m., Mohammad Islam wrote: > > trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java, > > line 26 > > <https://reviews.apache.org/r/9622/diff/5/?file=280099#file280099line26> > > > > Is it the base class for all messages? In that case, add that in this > > doc. will do > On April 12, 2013, 2:25 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java, line > > 96 > > <https://reviews.apache.org/r/9622/diff/5/?file=280108#file280108line96> > > > > why do we need ThreadLocal object? For optimization. As session is singlethreaded, having a single session for all the events will not be efficient. Having session for each event is also not efficient as creating session is not very cheap. If we have threadlocal, then a session will be created per worker thread calling the listener. So if that worker thread is supposed to batch 50 events, then there will be only one session for those 50 events. - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9622/#review18992 ----------------------------------------------------------- On April 11, 2013, 7:49 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9622/ > ----------------------------------------------------------- > > (Updated April 11, 2013, 7:49 p.m.) > > > Review request for oozie. > > > Description > ------- > > Description at https://issues.apache.org/jira/browse/OOZIE-1234 > > OOZIE-1209 generates events and handles them by calling appropriate > listeners. This patch provides JMS implementation of those listeners. Also, > the messages are serialized using JSON and there is a deserializer to > construct the Java object back from json. > > > This addresses bug OOZIE-1234. > https://issues.apache.org/jira/browse/OOZIE-1234 > > > Diffs > ----- > > trunk/client/pom.xml 1467063 > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JMSMessagingUtils.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/JSONMessageDeserializer.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/message/CoordinatorActionMessage.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/message/EventMessage.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/message/JobMessage.java > PRE-CREATION > > trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowJobMessage.java > PRE-CREATION > trunk/core/pom.xml 1467063 > trunk/core/src/main/java/org/apache/oozie/event/CoordinatorActionEvent.java > 1467063 > > trunk/core/src/main/java/org/apache/oozie/event/listener/JobEventListener.java > 1467063 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/JSONMessageSerializer.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageSerializer.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/jms/ConnectionContext.java > 1467063 > trunk/core/src/main/java/org/apache/oozie/jms/DefaultConnectionContext.java > 1467063 > trunk/core/src/main/java/org/apache/oozie/jms/JMSExceptionListener.java > 1467063 > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > PRE-CREATION > trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 1467063 > > trunk/core/src/test/java/org/apache/oozie/jms/TestDefaultConnectionContext.java > PRE-CREATION > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > PRE-CREATION > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > 1467063 > > trunk/core/src/test/java/org/apache/oozie/service/TestJMSAccessorService.java > 1467063 > trunk/pom.xml 1467063 > > Diff: https://reviews.apache.org/r/9622/diff/ > > > Testing > ------- > > Unit test cases added. Test case for JMS connection failure pending. End to > end test pending > > > Thanks, > > Virag Kothari > >
