----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11295/#review21168 -----------------------------------------------------------
-Action events need to be generated in ActionCheckX for START_MANUAL and FAILED -In some cases, KillX sets the action status to KILLED but doesn't queue ActionKillX. In such cases, wf action events need to be generated there. -The JMS job event listener is not configured to create workflow action messages. Will this be done in another JIRA? If so, we should not generate events for workflow action by default. - Virag Kothari On May 24, 2013, 10:01 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11295/ > ----------------------------------------------------------- > > (Updated May 24, 2013, 10:01 p.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1375 > > Note: > 1. The SignalXCommand part of the patch will be rebased after the bug-fix for > duplicate wf_job event generation > 2. Looking for better solution than not changing method handleNonTransient > from protected to public (visibleForTesting does not work outside packages) > > > This addresses bug OOZIE-1375. > https://issues.apache.org/jira/browse/OOZIE-1375 > > > Diffs > ----- > > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1486119 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1486119 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1486119 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1486119 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1486119 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1486119 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1486119 > trunk/core/src/main/resources/oozie-default.xml 1486119 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1486119 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java > 1486119 > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > 1486119 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1486119 > > Diff: https://reviews.apache.org/r/11295/diff/ > > > Testing > ------- > > Testcase added. Other test files including XTestCase edited to enhance > utility method createWfAction() to accept pending flag > > > Thanks, > > Mona Chitnis > >
