----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11295/#review21196 -----------------------------------------------------------
+1 after addressing one last comment trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java <https://reviews.apache.org/r/11295/#comment44023> USER_RETRY should be ignored here as events are not generated for that state - Virag Kothari On May 30, 2013, 1:48 a.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11295/ > ----------------------------------------------------------- > > (Updated May 30, 2013, 1:48 a.m.) > > > Review request for oozie. > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1375 > > > This addresses bug OOZIE-1375. > https://issues.apache.org/jira/browse/OOZIE-1375 > > > Diffs > ----- > > > trunk/client/src/main/java/org/apache/oozie/client/event/jms/MessageDeserializer.java > 1487638 > > trunk/client/src/main/java/org/apache/oozie/client/event/message/WorkflowActionMessage.java > PRE-CREATION > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionCheckXCommand.java > 1487638 > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionEndXCommand.java > 1487638 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionKillXCommand.java > 1487638 > > trunk/core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 1487638 > trunk/core/src/main/java/org/apache/oozie/command/wf/KillXCommand.java > 1487638 > trunk/core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java > 1487638 > trunk/core/src/main/java/org/apache/oozie/command/wf/WorkflowXCommand.java > 1487638 > trunk/core/src/main/java/org/apache/oozie/event/WorkflowActionEvent.java > 1487638 > > trunk/core/src/main/java/org/apache/oozie/event/messaging/MessageFactory.java > 1487638 > trunk/core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java > 1487638 > trunk/core/src/main/resources/oozie-default.xml 1487638 > trunk/core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 1487638 > > trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestWorkflowActionGetJPAExecutor.java > 1487638 > trunk/core/src/test/java/org/apache/oozie/jms/TestJMSJobEventListener.java > 1487638 > > trunk/core/src/test/java/org/apache/oozie/service/TestEventHandlerService.java > 1487638 > trunk/core/src/test/java/org/apache/oozie/test/XDataTestCase.java 1487638 > > Diff: https://reviews.apache.org/r/11295/diff/ > > > Testing > ------- > > Testcase added. Other test files including XTestCase edited to enhance > utility method createWfAction() to accept pending flag > > > Thanks, > > Mona Chitnis > >
