> On July 18, 2013, 11:51 p.m., Mona Chitnis wrote: > > /trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 256 > > <https://reviews.apache.org/r/11922/diff/4/?file=319448#file319448line256> > > > > so does this get an instance of ZKLogStreamingSerice if configured, by > > reflection?
Yes. To enable HA, you have to set the three ZK____Service classes in oozie-site.xml, which will overwrite their regular counterparts (e.g. Oozie will only load ZKXLogStreamingService or XLogStreamingService, but not both). > On July 18, 2013, 11:51 p.m., Mona Chitnis wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java, > > line 209 > > <https://reviews.apache.org/r/11922/diff/4/?file=319464#file319464line209> > > > > we should make this size configurable I'm not sure that's necessary; the while loop will make it keep reading from the InputStreamReader until it gets everything. The buffer is just a temporary internal thing; I'm not sure why the user should have to worry about it. > On July 18, 2013, 11:51 p.m., Mona Chitnis wrote: > > /trunk/core/src/test/java/org/apache/oozie/util/TestZKUtils.java, line 105 > > <https://reviews.apache.org/r/11922/diff/4/?file=319493#file319493line105> > > > > notnull checks like this can be removed, when followed by an operation > > on the object Will do. > On July 18, 2013, 11:51 p.m., Mona Chitnis wrote: > > /trunk/core/src/test/java/org/apache/oozie/service/DummyLogStreamingServlet.java, > > line 27 > > <https://reviews.apache.org/r/11922/diff/4/?file=319481#file319481line27> > > > > This class is not referred to other than in unit test and should be > > made inner class instead Will do. > On July 18, 2013, 11:51 p.m., Mona Chitnis wrote: > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKJobsConcurrencyService.java, > > line 79 > > <https://reviews.apache.org/r/11922/diff/4/?file=319485#file319485line79> > > > > Can some explanatory javadoc be added as to what is DummyZKOozie being > > initialized with, that directs this testcase? Will do. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11922/#review23447 ----------------------------------------------------------- On July 10, 2013, 12:22 a.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11922/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 12:22 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-615 > https://issues.apache.org/jira/browse/OOZIE-615 > > > Repository: oozie > > > Description > ------- > > See this comment for details: > https://issues.apache.org/jira/browse/OOZIE-615?focusedCommentId=13686181&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13686181 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1501618 > /trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1501618 > /trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1501618 > /trunk/core/pom.xml 1501618 > /trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/command/Command.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1501618 > > /trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java > 1501618 > > /trunk/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/service/PauseTransitService.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1501618 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/service/XLogService.java 1501618 > > /trunk/core/src/main/java/org/apache/oozie/service/XLogStreamingService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/ZKLocksService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java > 1501618 > /trunk/core/src/main/java/org/apache/oozie/util/ConfigUtils.java 1501618 > > /trunk/core/src/main/java/org/apache/oozie/util/FixedJsonInstanceSerializer.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/LockToken.java PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/MemoryLocks.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1501618 > /trunk/core/src/main/java/org/apache/oozie/util/ZKUtils.java PRE-CREATION > /trunk/core/src/main/resources/oozie-default.xml 1501618 > > /trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > 1501618 > /trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java > 1501618 > > /trunk/core/src/test/java/org/apache/oozie/service/DummyLogStreamingServlet.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java > 1501618 > > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 1501618 > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1501618 > /trunk/core/src/test/java/org/apache/oozie/test/ZKXTestCase.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java > 1501618 > /trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1501618 > /trunk/core/src/test/java/org/apache/oozie/util/TestZKUtils.java > PRE-CREATION > /trunk/distro/src/main/tomcat/ssl-web.xml 1501618 > /trunk/docs/src/site/twiki/AG_Install.twiki 1501618 > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1501618 > /trunk/docs/src/site/twiki/WebServicesAPI.twiki 1501618 > /trunk/pom.xml 1501618 > > Diff: https://reviews.apache.org/r/11922/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
