> On Aug. 7, 2013, 7:19 p.m., Alejandro Abdelnur wrote: > > /trunk/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java, > > line 157 > > <https://reviews.apache.org/r/11922/diff/6/?file=337985#file337985line157> > > > > are we loading the local log in memory? we should stream it in the same > > way we are doing for the remote logs.
Good catch, I didn't think about the StringWriter doing that. I've fixed this by doing some minor reworking of the new TimestampedMessageParser class so it can replace the XLogReader and be used for both local and remote logs. I have this working now, but need to write some more tests before putting up a new patch. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11922/#review24816 ----------------------------------------------------------- On Aug. 6, 2013, 9:04 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11922/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 9:04 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-615 > https://issues.apache.org/jira/browse/OOZIE-615 > > > Repository: oozie > > > Description > ------- > > See this comment for details: > https://issues.apache.org/jira/browse/OOZIE-615?focusedCommentId=13686181&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13686181 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1511121 > /trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1511121 > /trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1511121 > /trunk/core/pom.xml 1511121 > /trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/command/Command.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1511121 > > /trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java > 1511121 > > /trunk/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/service/PauseTransitService.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1511121 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/service/XLogService.java 1511121 > > /trunk/core/src/main/java/org/apache/oozie/service/XLogStreamingService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/ZKLocksService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java > 1511121 > /trunk/core/src/main/java/org/apache/oozie/util/ConfigUtils.java 1511121 > > /trunk/core/src/main/java/org/apache/oozie/util/FixedJsonInstanceSerializer.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/LockToken.java PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/MemoryLocks.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1511121 > /trunk/core/src/main/java/org/apache/oozie/util/ZKUtils.java PRE-CREATION > /trunk/core/src/main/resources/oozie-default.xml 1511121 > > /trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > 1511121 > /trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java > 1511121 > > /trunk/core/src/test/java/org/apache/oozie/service/DummyLogStreamingServlet.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java > 1511121 > > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 1511121 > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1511121 > /trunk/core/src/test/java/org/apache/oozie/test/ZKXTestCase.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java > 1511121 > /trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1511121 > /trunk/core/src/test/java/org/apache/oozie/util/TestZKUtils.java > PRE-CREATION > /trunk/distro/src/main/tomcat/ssl-web.xml 1511121 > /trunk/docs/src/site/twiki/AG_Install.twiki 1511121 > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1511121 > /trunk/docs/src/site/twiki/WebServicesAPI.twiki 1511121 > /trunk/pom.xml 1511121 > > Diff: https://reviews.apache.org/r/11922/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
