----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12866/#review23743 -----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/12866/#comment47616> this block can be combined with the one above nested within the if(ended) block, since it only involves checking eventProc (not getting overwritten above there) and setting status - event status in addition to SLAStatus, and sending out the event http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/12866/#comment47617> This else block is not pertaining to Database operations. How exactly is it useful for HA, since the slaCalc object is still passed from in-memory reference of same server? - Mona Chitnis On July 23, 2013, 4:59 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12866/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 4:59 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1405 > https://issues.apache.org/jira/browse/OOZIE-1405 > > > Repository: oozie > > > Description > ------- > > Changes done: > - Confirming against DB for start and duration miss also. This prevents wrong > events getting generated when lesser threads are configured. Also will be > required in case of HA. > - Still see SLA tests failing sometime. But this has reduced the probability > a lot. Will look at completely addressing it in another JIRA. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml > 1506109 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki > 1506109 > > Diff: https://reviews.apache.org/r/12866/diff/ > > > Testing > ------- > > Unit tests pass > > > Thanks, > > Rohini Palaniswamy > >
