----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12866/#review23984 -----------------------------------------------------------
+1 after minor comments requesting more log statements at couple of places in SLACalculator http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/12866/#comment47801> It'll be good to have log statement here indicating 'x' records loaded successfully to map and 'y' to history set http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/12866/#comment47802> would be good to have log.debug statement here simply saying 'processing job status event for job-id'. This will give us visibility atleast through logs to see how much time it took from queuing the job event to being picked up for sla processing. - Mona Chitnis On July 26, 2013, 9:52 p.m., Rohini Palaniswamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12866/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 9:52 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1472 > https://issues.apache.org/jira/browse/OOZIE-1472 > > > Repository: oozie > > > Description > ------- > > Changes done: > - Confirming against DB for start and duration miss also. This prevents wrong > events getting generated when lesser threads are configured. Also will be > required in case of HA. > - Still see SLA tests failing sometime. But this has reduced the probability > a lot. Will look at completely addressing it in another JIRA. > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/oozie/trunk/client/src/main/java/org/apache/oozie/client/event/message/SLAMessage.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculator.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLAOperations.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/resources/oozie-log4j.properties > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestJMSTopicService.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEmailEventListener.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/sla/TestSLAService.java > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/wf-job-sla.xml > 1507430 > > http://svn.apache.org/repos/asf/oozie/trunk/docs/src/site/twiki/DG_SLAMonitoring.twiki > 1507430 > > Diff: https://reviews.apache.org/r/12866/diff/ > > > Testing > ------- > > Unit tests pass > > > Thanks, > > Rohini Palaniswamy > >
