----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review24807 -----------------------------------------------------------
/trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java <https://reviews.apache.org/r/13362/#comment48932> These are not used until line 686/687 and can be declared in that else block instead of up here /trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetRunningPastEndtimeJPAExecutor.java <https://reviews.apache.org/r/13362/#comment48931> List<String> execute /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java <https://reviews.apache.org/r/13362/#comment48930> Unused Import /trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetRunningPastEndtimeJPAExecutor.java <https://reviews.apache.org/r/13362/#comment48928> Unused import /trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetRunningPastEndtimeJPAExecutor.java <https://reviews.apache.org/r/13362/#comment48926> Don't need this comment here /trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetRunningPastEndtimeJPAExecutor.java <https://reviews.apache.org/r/13362/#comment48929> Can you add some more tests? Like some where the job(s) shouldn't returned by the CoordJobsGetRunningPastEndtime JPA command. Have you done any manual testing? (you should be able to play with the computer clock to "trick" Oozie) - Robert Kanter On Aug. 6, 2013, 11:36 p.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 11:36 p.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > /trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1511139 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1511139 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1511139 > > /trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetRunningPastEndtimeJPAExecutor.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetRunningPastEndtimeJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
