> On Aug. 9, 2013, 4:56 p.m., Rohini Palaniswamy wrote: > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java, > > line 116 > > <https://reviews.apache.org/r/13362/diff/3/?file=338699#file338699line116> > > > > Can we have some test cases for DST transitions? > > Bowen Zhang wrote: > Can you be more specific about DST transition? what do you want to test? > We are all using UTC right here.
Look at TestCoordELFunctions.testCurrent for Spring and Winter DST transition cases. Adding/Subtracting the frequency interval every time in the loop instead of multiplying like it is done right now gave different results. Refer to the comments in CoordELFunctions.coord_currentRange_sync. Since you are trying to do the same thing in getNextActionMeasureTime, you might have wrong materializations during DST and currently there are no test cases to catch it. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13362/#review24923 ----------------------------------------------------------- On Aug. 8, 2013, 6:33 p.m., Bowen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13362/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 6:33 p.m.) > > > Review request for oozie, Robert Kanter and Rohini Palaniswamy. > > > Repository: oozie > > > Description > ------- > > oozie-1306 cron scheduling for coordinator job > > > Diffs > ----- > > /trunk/core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 1511139 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 1511139 > > /trunk/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 1511139 > > /trunk/core/src/main/java/org/apache/oozie/executor/jpa/CoordJobsGetRunningPastEndtimeJPAExecutor.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 1511139 > > /trunk/core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobsGetRunningPastEndtimeJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/13362/diff/ > > > Testing > ------- > > > Thanks, > > Bowen Zhang > >
