> On Aug. 7, 2013, 7:19 p.m., Alejandro Abdelnur wrote: > > /trunk/core/src/main/java/org/apache/oozie/util/ConfigUtils.java, line 78 > > <https://reviews.apache.org/r/11922/diff/6/?file=337993#file337993line78> > > > > is his method only visible for testing? is so, can we make it package > > private? > > Robert Kanter wrote: > I can't because some of the tests are in another package.
You can add @VisibleForTesting annotations to note that the method is only public for testing. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11922/#review24816 ----------------------------------------------------------- On Aug. 13, 2013, 5:35 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11922/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2013, 5:35 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-615 > https://issues.apache.org/jira/browse/OOZIE-615 > > > Repository: oozie > > > Description > ------- > > See this comment for details: > https://issues.apache.org/jira/browse/OOZIE-615?focusedCommentId=13686181&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13686181 > > > Diffs > ----- > > /trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1513595 > /trunk/client/src/main/java/org/apache/oozie/client/OozieClient.java > 1513595 > /trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 1513595 > /trunk/core/pom.xml 1513595 > /trunk/core/src/main/java/org/apache/oozie/BaseEngine.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/BundleEngine.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/DagEngine.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/command/Command.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/command/XCommand.java 1513595 > > /trunk/core/src/main/java/org/apache/oozie/service/ActionCheckerService.java > 1513595 > > /trunk/core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/service/PauseTransitService.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/service/PurgeService.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/service/RecoveryService.java > 1513595 > > /trunk/core/src/main/java/org/apache/oozie/service/StatusTransitService.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/service/XLogService.java 1513595 > > /trunk/core/src/main/java/org/apache/oozie/service/XLogStreamingService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/service/ZKLocksService.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/servlet/ServicesLoader.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/servlet/V2AdminServlet.java > 1513595 > /trunk/core/src/main/java/org/apache/oozie/util/ConfigUtils.java 1513595 > > /trunk/core/src/main/java/org/apache/oozie/util/FixedJsonInstanceSerializer.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/LockToken.java PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/MemoryLocks.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/util/MultiFileReader.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > PRE-CREATION > > /trunk/core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > PRE-CREATION > /trunk/core/src/main/java/org/apache/oozie/util/XLogReader.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/util/XLogStreamer.java 1513595 > /trunk/core/src/main/java/org/apache/oozie/util/ZKUtils.java PRE-CREATION > /trunk/core/src/main/resources/oozie-default.xml 1513595 > > /trunk/core/src/test/java/org/apache/oozie/TestCoordinatorEngineStreamLog.java > 1513595 > /trunk/core/src/test/java/org/apache/oozie/command/TestXCommand.java > 1513595 > > /trunk/core/src/test/java/org/apache/oozie/service/DummyLogStreamingServlet.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogService.java > 1513595 > > /trunk/core/src/test/java/org/apache/oozie/service/TestXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKJobsConcurrencyService.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 1513595 > > /trunk/core/src/test/java/org/apache/oozie/servlet/MockDagEngineService.java > 1513595 > /trunk/core/src/test/java/org/apache/oozie/test/ZKXTestCase.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/util/TestLogStreamer.java > 1513595 > /trunk/core/src/test/java/org/apache/oozie/util/TestMemoryLocks.java > 1513595 > /trunk/core/src/test/java/org/apache/oozie/util/TestMultiFileReader.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/util/TestSimplifiedTimestampedMessageParser.java > PRE-CREATION > > /trunk/core/src/test/java/org/apache/oozie/util/TestTimestampedMessageParser.java > PRE-CREATION > /trunk/core/src/test/java/org/apache/oozie/util/TestXLogFilter.java 1513595 > /trunk/core/src/test/java/org/apache/oozie/util/TestXLogReader.java 1513595 > /trunk/core/src/test/java/org/apache/oozie/util/TestZKUtils.java > PRE-CREATION > /trunk/distro/src/main/tomcat/ssl-web.xml 1513595 > /trunk/docs/src/site/twiki/AG_Install.twiki 1513595 > /trunk/docs/src/site/twiki/DG_CommandLineTool.twiki 1513595 > /trunk/docs/src/site/twiki/WebServicesAPI.twiki 1513595 > /trunk/pom.xml 1513595 > > Diff: https://reviews.apache.org/r/11922/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
