> On Sept. 24, 2013, 12:18 a.m., Ryota Egashira wrote: > > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java, line 63 > > <https://reviews.apache.org/r/14220/diff/1/?file=353592#file353592line63> > > > > not private?
changed to default > On Sept. 24, 2013, 12:18 a.m., Ryota Egashira wrote: > > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java, line 596 > > <https://reviews.apache.org/r/14220/diff/1/?file=353592#file353592line596> > > > > sqlfile is not updated in ddlTweaksFor50. for mysql, possible to add > > sql statement used, oracle/others, doing clob conversion in java(not sql > > level), so probably need to ignore fixed > On Sept. 24, 2013, 12:18 a.m., Ryota Egashira wrote: > > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java, line 598 > > <https://reviews.apache.org/r/14220/diff/1/?file=353592#file353592line598> > > > > if run=false, could be NPE? fixed > On Sept. 24, 2013, 12:18 a.m., Ryota Egashira wrote: > > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java, line 1097 > > <https://reviews.apache.org/r/14220/diff/1/?file=353592#file353592line1097> > > > > nitpicking.. reflected fixed - Virag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14220/#review26329 ----------------------------------------------------------- On Dec. 15, 2013, 6:10 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14220/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2013, 6:10 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1548 > https://issues.apache.org/jira/browse/OOZIE-1548 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1548 > > > Diffs > ----- > > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1550993 > trunk/tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java > 1550993 > > Diff: https://reviews.apache.org/r/14220/diff/ > > > Testing > ------- > > E2E-Tested upgrade from 4.0 on derby, postgres, mysql, oracle > E2E-Tested upgrade from 3.3 on derby. > > > Thanks, > > Virag Kothari > >
