----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14220/#review30566 -----------------------------------------------------------
Ship it! LGTM; though it might be good for Mona or Ryota to take another look too. One question: you took out the MySQL MEDIUMTEXT stuff because it will use MEDIUMTEXT when you upgrade from the Oozie 4 DB to Oozie 5 DB regardless of whether or not it was MEDIUMTEXT or TEXT, right? - Robert Kanter On Dec. 15, 2013, 6:10 p.m., Virag Kothari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14220/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2013, 6:10 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1548 > https://issues.apache.org/jira/browse/OOZIE-1548 > > > Repository: oozie > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1548 > > > Diffs > ----- > > trunk/tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java 1550993 > trunk/tools/src/test/java/org/apache/oozie/tools/TestOozieDBCLI.java > 1550993 > > Diff: https://reviews.apache.org/r/14220/diff/ > > > Testing > ------- > > E2E-Tested upgrade from 4.0 on derby, postgres, mysql, oracle > E2E-Tested upgrade from 3.3 on derby. > > > Thanks, > > Virag Kothari > >
