----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16669/#review31314 -----------------------------------------------------------
webapp/src/main/webapp/oozie-console.js <https://reviews.apache.org/r/16669/#comment59774> space after full stop. Why reassign errorMsg if already present? Probably you meant !errorMsg webapp/src/main/webapp/oozie-console.js <https://reviews.apache.org/r/16669/#comment59776> Should the condition be > 2 instead of = 4? Remember seeing that in the examples. webapp/src/main/webapp/oozie-console.js <https://reviews.apache.org/r/16669/#comment59777> What is this for? Does not seem to be used and don't see such a field for XHR searching online. webapp/src/main/webapp/oozie-console.js <https://reviews.apache.org/r/16669/#comment59780> Do not comment out. Remove it altogether. Also please set initial text on the textarea to "Enter the list of actions in the format similar to 1,3-4,7-40 to get logs for specific coordinator actions. To get the log for the coordinator job, leave the actions field empty" so that users know leaving it empty will give coord job log webapp/src/main/webapp/oozie-console.js <https://reviews.apache.org/r/16669/#comment59781> Remove this empty if condition - Rohini Palaniswamy On Jan. 6, 2014, 9:11 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16669/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 9:11 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1661 > https://issues.apache.org/jira/browse/OOZIE-1661 > > > Repository: oozie-git > > > Description > ------- > > UI improvement - log streaming. > 1. Support partial streaming of logs. > UI doesn't support partial displaying of logs, logs are displayed only when > request completes. > 2.Current ajax call timeout is 30 sec(except coord logs with action list). > If log fetch request takes more than 30 sec, connection is terminated by UI > and logs are never displayed. > Changing it to no timeout. Timeout should be handled by Server. > 3.Code reuse : Coord,bundle and WF have their own logic to fetch and display > logs. > Adding a function to retrieve and display logs, will be used by all component. > 4.For coord job logs, "action list" and "fetch logs" components are on bottom > of page, hard to see for user. > Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" > button. > > > Diffs > ----- > > webapp/src/main/webapp/oozie-console.js e1b4588 > > Diff: https://reviews.apache.org/r/16669/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
