> On Jan. 7, 2014, 10:46 p.m., Rohini Palaniswamy wrote: > > webapp/src/main/webapp/oozie-console.js, line 37 > > <https://reviews.apache.org/r/16669/diff/2/?file=417637#file417637line37> > > > > space after full stop. Why reassign errorMsg if already present? > > Probably you meant !errorMsg
Sorry for that, i mean !errorMsg. > On Jan. 7, 2014, 10:46 p.m., Rohini Palaniswamy wrote: > > webapp/src/main/webapp/oozie-console.js, line 69 > > <https://reviews.apache.org/r/16669/diff/2/?file=417637#file417637line69> > > > > What is this for? Does not seem to be used and don't see such a field > > for XHR searching online. This to get partial logs. Changes the logic to store length, rather than storing full text. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16669/#review31314 ----------------------------------------------------------- On Jan. 8, 2014, 9:23 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16669/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2014, 9:23 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1661 > https://issues.apache.org/jira/browse/OOZIE-1661 > > > Repository: oozie-git > > > Description > ------- > > UI improvement - log streaming. > 1. Support partial streaming of logs. > UI doesn't support partial displaying of logs, logs are displayed only when > request completes. > 2.Current ajax call timeout is 30 sec(except coord logs with action list). > If log fetch request takes more than 30 sec, connection is terminated by UI > and logs are never displayed. > Changing it to no timeout. Timeout should be handled by Server. > 3.Code reuse : Coord,bundle and WF have their own logic to fetch and display > logs. > Adding a function to retrieve and display logs, will be used by all component. > 4.For coord job logs, "action list" and "fetch logs" components are on bottom > of page, hard to see for user. > Move it to top. Removed refresh button. Logs will be retrieved by "Get logs" > button. > > > Diffs > ----- > > webapp/src/main/webapp/oozie-console.js e1b4588 > > Diff: https://reviews.apache.org/r/16669/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
