----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17817/#review33987 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/AuthUrlClient.java <https://reviews.apache.org/r/17817/#comment63885> this method seems out of place in this Auth.. class. You can place it in the LogStreaming class itself core/src/main/java/org/apache/oozie/util/AuthUrlClient.java <https://reviews.apache.org/r/17817/#comment63886> should not have "key=;" inserted when value is null. null check for value before appending key itself - Mona Chitnis On Feb. 6, 2014, 9:10 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17817/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2014, 9:10 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1689 > https://issues.apache.org/jira/browse/OOZIE-1689 > > > Repository: oozie-git > > > Description > ------- > > HA support for OOZIE-7(Ability to view the log information corresponding to > particular coordinator action) > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java > 8dc8b4b > core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 79f8883 > core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java > 29bca41 > > Diff: https://reviews.apache.org/r/17817/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
