-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17817/#review34001
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/util/AuthUrlClient.java
<https://reviews.apache.org/r/17817/#comment63902>

    This class will be used for communicating with other server.
    
    Other call may also need to convert paramToString. so, it better to put it 
here so that other can use it and share same logic.



core/src/main/java/org/apache/oozie/util/AuthUrlClient.java
<https://reviews.apache.org/r/17817/#comment63904>

    If value it null, then it will "key=&".
    
    It good to propagate same key/value even if value is empty to avoid NPE at 
server side.


- Purshotam Shah


On Feb. 6, 2014, 9:10 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17817/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2014, 9:10 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1689
>     https://issues.apache.org/jira/browse/OOZIE-1689
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> HA support for OOZIE-7(Ability to view the log information corresponding to 
> particular coordinator action)
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/service/ZKXLogStreamingService.java 
> 8dc8b4b 
>   core/src/main/java/org/apache/oozie/util/AuthUrlClient.java 79f8883 
>   core/src/test/java/org/apache/oozie/service/TestZKXLogStreamingService.java 
> 29bca41 
> 
> Diff: https://reviews.apache.org/r/17817/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>

Reply via email to