[ 
https://issues.apache.org/jira/browse/OOZIE-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13897179#comment-13897179
 ] 

Robert Kanter commented on OOZIE-1618:
--------------------------------------

Makes sense.  

Can you look into the javac warnings?  
The actual variable resolution added to {{SubmitXCommand}} is then ignored and 
later done somewhere else essentially.  So, if the user is submitting a 
workflow (not a dry-run), this happens twice.  I think it would be better if we 
put this code into the {{else}} statement for {{if (!dryrun)}}.  It would also 
be good to add a comment saying what this code is doing (e.g. "Checking 
variable substitution for dryrun").

After that, I think it should be good to go

> dryrun should check variable substitution in workflow.xml
> ---------------------------------------------------------
>
>                 Key: OOZIE-1618
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1618
>             Project: Oozie
>          Issue Type: Improvement
>            Reporter: Bowen Zhang
>            Assignee: Bowen Zhang
>         Attachments: oozie-1618.patch, oozie-1618.patch
>
>
> Currently, dryrun doesn't check variable substitution in workflow.xml, like 
> in the configuration section.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to