-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17991/#review34268
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/WorkflowJobBean.java
<https://reviews.apache.org/r/17991/#comment64297>

    Would these queries slow down the DB or fetch too much result into the 
server? Are there alternate ways to figure if the w/f is triggered for a coord 
action and not a subflow or an independent w/f instead of using like '%...'



core/src/main/java/org/apache/oozie/command/PurgeXCommand.java
<https://reviews.apache.org/r/17991/#comment64298>

    Is there additional memory pressure here ?
    
    Also based on what the limit is and how many rows qualify, 
GET_COMPLETED_COORD_ACTIONS_OLDER_THAN may be executed several times. 


- Srikanth Sundarrajan


On Feb. 12, 2014, 5:05 a.m., Srikanth Sundarrajan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17991/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2014, 5:05 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1532
>     https://issues.apache.org/jira/browse/OOZIE-1532
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> Purging should remove completed children job for long running coordinator jobs
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8 
>   core/src/main/java/org/apache/oozie/WorkflowJobBean.java 3194995 
>   core/src/main/java/org/apache/oozie/command/PurgeXCommand.java 9973719 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsDeleteJPAExecutor.java
>  PRE-CREATION 
>   
> core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForPurgeJPAExecutor.java
>  PRE-CREATION 
>   core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java 666271e 
>   
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteJPAExecutor.java
>  PRE-CREATION 
>   
> core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForPurgeJPAExecutor.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17991/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Srikanth Sundarrajan
> 
>

Reply via email to