> On Feb. 12, 2014, 5:35 a.m., Srikanth Sundarrajan wrote: > > core/src/main/java/org/apache/oozie/WorkflowJobBean.java, line 87 > > <https://reviews.apache.org/r/17991/diff/1/?file=483265#file483265line87> > > > > Would these queries slow down the DB or fetch too much result into the > > server? Are there alternate ways to figure if the w/f is triggered for a > > coord action and not a subflow or an independent w/f instead of using like > > '%...'
In WorkflowJobsGetForPurgeJPAExecutor.java, we set limit in the max results, so we won't fetch too many results. There is no difference between wf triggered by a coord Action or being a subworkflow of a parent except the ending string pattern of its parent_id. And to use a join query to verify a workflow being triggered by a coord action is a lot more expensive and I only see one place in our entire code base where we have a join query on a particular bundle id to fetch all its coord actions(which is less expensive than getting all old workflow which have coord parents) > On Feb. 12, 2014, 5:35 a.m., Srikanth Sundarrajan wrote: > > core/src/main/java/org/apache/oozie/command/PurgeXCommand.java, line 97 > > <https://reviews.apache.org/r/17991/diff/1/?file=483266#file483266line97> > > > > Is there additional memory pressure here ? > > > > Also based on what the limit is and how many rows qualify, > > GET_COMPLETED_COORD_ACTIONS_OLDER_THAN may be executed several times. I don't see the memory pressure here since we are fetching beans chunk by chunk, not in a single load, just like how we fetch workflows, coordjobs, and bundle jobs in the loadState() method. And GET_COMPLETED_COORD_ACTIONS_OLDER_THAN is SUPPOSED to be executed several time since we are fetching objects chunk by chunk. - Bowen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17991/#review34268 ----------------------------------------------------------- On Feb. 12, 2014, 5:05 a.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17991/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 5:05 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1532 > https://issues.apache.org/jira/browse/OOZIE-1532 > > > Repository: oozie-git > > > Description > ------- > > Purging should remove completed children job for long running coordinator jobs > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 03a7ed8 > core/src/main/java/org/apache/oozie/WorkflowJobBean.java 3194995 > core/src/main/java/org/apache/oozie/command/PurgeXCommand.java 9973719 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsDeleteJPAExecutor.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionsGetForPurgeJPAExecutor.java > PRE-CREATION > core/src/test/java/org/apache/oozie/command/TestPurgeXCommand.java 666271e > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsDeleteJPAExecutor.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordActionsGetForPurgeJPAExecutor.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/17991/diff/ > > > Testing > ------- > > > Thanks, > > Srikanth Sundarrajan > >
