----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review38930 -----------------------------------------------------------
We should call it dataInPartition as it only works if there is one partition. I like the idea of the generalization, but I can't seem to be able to think of another use case where the current generalization will actually help. Can you list out some usecases so that we are sure that this generalization is actually useful and can be applied elsewhere? - Rohini Palaniswamy On March 28, 2014, 12:38 p.m., Satish Mittal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19449/ > ----------------------------------------------------------- > > (Updated March 28, 2014, 12:38 p.m.) > > > Review request for oozie and Ryota Egashira. > > > Repository: oozie-git > > > Description > ------- > > Currently oozie provides coord EL functions to get partition filter string > (where key-values are separated by AND) for various action types - > java/pig/hive. However this doesn't work in other cases, e.g. hive action > that performs export/import of hive partition. In that case, the partition > value is expected to be in a different format: > (col1="value1",col2="value2"...). > > If we use any existing EL function like coord:dataInPartitionFilter, the > value of partition looks like: > (minute='00' AND month='03' AND year='2014' AND hour='09' AND day='11') > In this case, Hive export fails with error: > FAILED: ParseException line 1:51 mismatched input 'AND' expecting ) near > ''00'' in export statement > > We need to add a new EL function that returns partition value in the above > format. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java e5f0146 > core/src/main/resources/oozie-default.xml 34362aa > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f46f1ec > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 44a3d54 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java d797f9b > > Diff: https://reviews.apache.org/r/19449/diff/ > > > Testing > ------- > > - Manually verified the new EL function on my local setup. > - Added new test cases for the same. > > > Thanks, > > Satish Mittal > >
