> On June 16, 2014, 2:02 a.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java, lines > > 293-298 > > <https://reviews.apache.org/r/19449/diff/4/?file=609416#file609416line293> > > > > Can you put this code in if (type equals hive-export) block?
Done. > On June 16, 2014, 2:02 a.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java, line 301 > > <https://reviews.apache.org/r/19449/diff/4/?file=609418#file609418line301> > > > > Aren't there 2 parameters here? Why would it fail? The expected string has 2 parameters, but the actual one (expr = "${coord:dataInPartitions('ABCD')}") has only one param. You have probably missed that. > On June 16, 2014, 2:02 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki, line 2845 > > <https://reviews.apache.org/r/19449/diff/4/?file=609419#file609419line2845> > > > > This needs to be changed to type Done > On June 16, 2014, 2:02 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki, line 2848 > > <https://reviews.apache.org/r/19449/diff/4/?file=609419#file609419line2848> > > > > Can you say that currently the only type supported is hive-export and > > type hive-export can be used in Hive action to create .... > > > > Also mention that there can be only one partition instance Done > On June 16, 2014, 2:02 a.m., Rohini Palaniswamy wrote: > > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki, line 3007 > > <https://reviews.apache.org/r/19449/diff/4/?file=609419#file609419line3007> > > > > We should make the EL function return the value without the enclosing > > braces( ) as most of the others do not. i.e > > > > export table ${sourceDatabase}.${sourceTable} partition > > (${sourcePartition}) to '${sourceStagingDir}'; Done - Satish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19449/#review45715 ----------------------------------------------------------- On June 16, 2014, 1:09 p.m., Satish Mittal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/19449/ > ----------------------------------------------------------- > > (Updated June 16, 2014, 1:09 p.m.) > > > Review request for oozie, Ryota Egashira and Rohini Palaniswamy. > > > Repository: oozie-git > > > Description > ------- > > Currently oozie provides coord EL functions to get partition filter string > (where key-values are separated by AND) for various action types - > java/pig/hive. However this doesn't work in other cases, e.g. hive action > that performs export/import of hive partition. In that case, the partition > value is expected to be in a different format: > (col1="value1",col2="value2"...). > > If we use any existing EL function like coord:dataInPartitionFilter, the > value of partition looks like: > (minute='00' AND month='03' AND year='2014' AND hour='09' AND day='11') > In this case, Hive export fails with error: > FAILED: ParseException line 1:51 mismatched input 'AND' expecting ) near > ''00'' in export statement > > We need to add a new EL function that returns partition value in the above > format. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/coord/HCatELFunctions.java e5f0146 > core/src/main/resources/oozie-default.xml c9d9591 > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java f63b682 > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki 11018b0 > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java d797f9b > > Diff: https://reviews.apache.org/r/19449/diff/ > > > Testing > ------- > > - Manually verified the new EL function on my local setup. > - Added new test cases for the same. > > > Thanks, > > Satish Mittal > >
