[ 
https://issues.apache.org/jira/browse/OOZIE-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Kanter updated OOZIE-1817:
---------------------------------

    Attachment: OOZIE-1817.patch

The new patch:
- Does a bunch of misc improvements that Gilad suggested on ReviewBoard
- Removed XLogReporter for printing to the oozie-instrumentation log and 
instead does a pretty-print of the JSON shown on the metrics endpoint
-- I was able to remove XLogReporter, which being a copy-paste from Metrics 
code is "ugly"
-- The output doesn't have all the extra log4j prefix stuff now, which is more 
similar to the Instrumentation's output
-- Pretty-printing the JSON is actually twice as fast as XLogReporter.  I 
temporarily added some timers to check this.  Here's some of the metrics after 
running for ~30min:
||Metric|||XLogReporter (ms)||Pretty-Print JSON (ms)||
||min|31.0|10.0|
||max|274.0|170.0|
||mean|48.46666666666666|21.96551724137931|
||stddev|43.608551307357565|28.96239280591876|
-- This allowed me to simplify the code a lot

> Oozie timers are not biased
> ---------------------------
>
>                 Key: OOZIE-1817
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1817
>             Project: Oozie
>          Issue Type: Improvement
>          Components: monitoring
>    Affects Versions: 4.0.0
>            Reporter: Gilad Wolff
>            Assignee: Robert Kanter
>         Attachments: OOZIE-1817.patch, OOZIE-1817.patch, OOZIE-1817.patch, 
> OOZIE-1817.patch, OOZIE-1817.patch
>
>
> Oozie timers are not biased, that is, the statistical metrics they expose are 
> over the run-time of the Oozie server instead of a window of time. This makes 
> them not very useful especially after the server has been running for a while 
> (codehale has very efficient and easy to use biased histograms that can be 
> used instead).



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to