> On May 19, 2014, 9:51 p.m., Rohini Palaniswamy wrote: > > On scale with lot of missing dependencies, this code will have serious > > problems. Iterating on all missing dependencies is going to take a long > > time and synchronized can block other calls. You need another data > > structure (reverse lookup map) which quickly gives the keys for a action id > > that you need to pick so that this method executes really quickly and does > > not hold other threads.
added actionPartitionMap in SimpleHCatDependencyCache for revert lookup > On May 19, 2014, 9:51 p.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java, > > line 92 > > <https://reviews.apache.org/r/18754/diff/7/?file=584045#file584045line92> > > > > Why wait for 30 seconds? this 30 sec is timeout until predicate meets, doesn't mean waiting 30 secs. - Ryota ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18754/#review43416 ----------------------------------------------------------- On May 19, 2014, 5:07 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18754/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 5:07 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1492 > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 43d5103 > > core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 2e5cd47 > > core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java > 6f127c4 > > core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java > df3afd3 > > core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java > e8e3ebc > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > f5304ca > > core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 985dcab > > core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > da09727 > > core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java > cfdfbd1 > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > ef71fb0 > > Diff: https://reviews.apache.org/r/18754/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
