----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18754/#review43645 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java <https://reviews.apache.org/r/18754/#comment77924> Nitpick. removeNonWaitingCoordActions - plural core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java <https://reviews.apache.org/r/18754/#comment77927> The code still iterates on all entries (tables). Please iterate on coordActions and pick the action related data directly from actionPartitionMap. For that the first key of actionPartitionMap should be actionId core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/18754/#comment77925> Please add a isHighlyAvailableMode() to JobsConcurrencyService which always returns false and returns true in ZKJobsConcurrencyService. multipleServerRunning is not same as being in HA mode. When the other server is down while this code runs, this will never get scheduled. core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java <https://reviews.apache.org/r/18754/#comment77926> You should also remove the actionid from the new actionPartitionMap datastructure. - Rohini Palaniswamy On May 21, 2014, 1:55 a.m., Ryota Egashira wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18754/ > ----------------------------------------------------------- > > (Updated May 21, 2014, 1:55 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1492 > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-1492 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 43d5103 > > core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java > 2e5cd47 > > core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java > 6f127c4 > > core/src/main/java/org/apache/oozie/dependency/hcat/HCatDependencyCache.java > df3afd3 > > core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java > e8e3ebc > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > f5304ca > core/src/main/java/org/apache/oozie/service/JobsConcurrencyService.java > 27c97e6 > > core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java > 985dcab > core/src/main/java/org/apache/oozie/service/ZKJobsConcurrencyService.java > 611b74c > > core/src/test/java/org/apache/oozie/command/coord/TestCoordPushDependencyCheckXCommand.java > da09727 > > core/src/test/java/org/apache/oozie/service/TestHAPartitionDependencyManagerService.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerEhcache.java > cfdfbd1 > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > ef71fb0 > > Diff: https://reviews.apache.org/r/18754/diff/ > > > Testing > ------- > > > Thanks, > > Ryota Egashira > >
