-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23225/
-----------------------------------------------------------

(Updated July 3, 2014, 6:08 a.m.)


Review request for oozie.


Changes
-------

Fix related test failures :
* TestCoordMaterializeTriggerService.testCoordMaterializeTriggerService3
* TestLiteWorkflowAppParser.testParser


Bugs: OOZIE-1890
    https://issues.apache.org/jira/browse/OOZIE-1890


Repository: oozie-git


Description
-------

I added ConfigurationService.OozieConfigs to contains all the configuration 
from oozie-default and oozie-site.
OozieConfigs.OozieConfig consist of name and value, So no need code default.


long warnThresholdMs = 
ConfigurationService.OozieConfigs.getLong(WARN_THRESHOLD_KEY);


Diffs (updated)
-----

  core/src/main/conf/oozie-site.xml 32f87f5 
  core/src/main/java/org/apache/oozie/action/ActionExecutor.java 09050c4 
  core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProvider.java 
bd55491 
  core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java 
fe31d7b 
  core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 
94b55cf 
  
core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 
044b56f 
  core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java 411b122 
  
core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java 
8f0e352 
  core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java 2d4fba9 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java
 0a9e4fa 
  
core/src/main/java/org/apache/oozie/command/coord/CoordActionNotificationXCommand.java
 562b211 
  
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
 23bafb8 
  
core/src/main/java/org/apache/oozie/command/coord/CoordPushDependencyCheckXCommand.java
 ae71924 
  core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 
11fde6f 
  core/src/main/java/org/apache/oozie/command/wf/JobXCommand.java 1d7ca82 
  core/src/main/java/org/apache/oozie/command/wf/NotificationXCommand.java 
651b5fd 
  core/src/main/java/org/apache/oozie/event/MemoryEventQueue.java f32afb4 
  
core/src/main/java/org/apache/oozie/executor/jpa/CoordActionGetForInfoJPAExecutor.java
 b5efd12 
  core/src/main/java/org/apache/oozie/jms/JMSJobEventListener.java f155fe2 
  core/src/main/java/org/apache/oozie/service/ActionCheckerService.java 9cbc223 
  core/src/main/java/org/apache/oozie/service/ActionService.java 7d87502 
  core/src/main/java/org/apache/oozie/service/AuthorizationService.java 9e6b76f 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java 093eb08 
  core/src/main/java/org/apache/oozie/service/CallbackService.java ce3cbaf 
  core/src/main/java/org/apache/oozie/service/ConfigurationService.java 798782e 
  
core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java 
1dac7e8 
  core/src/main/java/org/apache/oozie/service/DBLiteWorkflowStoreService.java 
88dc0d4 
  core/src/main/java/org/apache/oozie/service/ELService.java 62fb2d6 
  core/src/main/java/org/apache/oozie/service/EventHandlerService.java 4207a07 
  core/src/main/java/org/apache/oozie/service/HCatAccessorService.java ebef79b 
  core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 
e2db6a6 
  core/src/main/java/org/apache/oozie/service/InstrumentationService.java 
e17ceb8 
  core/src/main/java/org/apache/oozie/service/JMSAccessorService.java 7fe449a 
  core/src/main/java/org/apache/oozie/service/JMSTopicService.java 1646a17 
  core/src/main/java/org/apache/oozie/service/JPAService.java 857ec29 
  core/src/main/java/org/apache/oozie/service/JvmPauseMonitorService.java 
0f1a5f6 
  core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java 
9169103 
  core/src/main/java/org/apache/oozie/service/PauseTransitService.java e1bfa2b 
  core/src/main/java/org/apache/oozie/service/PurgeService.java 9eeee30 
  core/src/main/java/org/apache/oozie/service/RecoveryService.java b22a98d 
  core/src/main/java/org/apache/oozie/service/SchedulerService.java cb5bd74 
  core/src/main/java/org/apache/oozie/service/SchemaService.java 691148b 
  core/src/main/java/org/apache/oozie/service/Service.java 33b2619 
  core/src/main/java/org/apache/oozie/service/Services.java 398e91f 
  core/src/main/java/org/apache/oozie/service/ShareLibService.java c31d587 
  core/src/main/java/org/apache/oozie/service/StatusTransitService.java 21ac25f 
  core/src/main/java/org/apache/oozie/service/URIHandlerService.java d42f974 
  core/src/main/java/org/apache/oozie/service/UUIDService.java 7489a53 
  core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 05efefb 
  core/src/main/java/org/apache/oozie/service/XLogStreamingService.java 1bf636b 
  core/src/main/java/org/apache/oozie/service/ZKUUIDService.java 33d782b 
  core/src/main/java/org/apache/oozie/servlet/AuthFilter.java 9fb7147 
  core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java 541faca 
  core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java 8a34763 
  core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 47c723d 
  core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java 
fbf701b 
  core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329 
  core/src/main/java/org/apache/oozie/util/ConfigUtils.java cdf6b48 
  core/src/main/java/org/apache/oozie/util/DateUtils.java 6f584a2 
  core/src/main/java/org/apache/oozie/util/StatusUtils.java 8132f9c 
  core/src/main/java/org/apache/oozie/util/XLogFilter.java a1a7fbc 
  core/src/main/java/org/apache/oozie/util/ZKUtils.java 885b656 
  core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java 
e47e619 
  core/src/main/resources/oozie-default.xml 982c82f 
  core/src/test/java/org/apache/oozie/action/email/TestEmailActionExecutor.java 
1800e3a 
  
core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 
c59a263 
  
core/src/test/java/org/apache/oozie/command/coord/TestCoordActionNotificationXCommand.java
 ae47516 
  core/src/test/java/org/apache/oozie/command/wf/TestNotificationXCommand.java 
5845041 
  core/src/test/java/org/apache/oozie/service/TestConfigurationService.java 
80495c8 
  core/src/test/java/org/apache/oozie/service/TestShareLibService.java 05460b4 
  
core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java
 b47f808 
  
sharelib/distcp/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java
 b075957 
  
sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java
 e9a8465 
  
sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java 
322f498 
  
sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java
 ce8a09b 

Diff: https://reviews.apache.org/r/23225/diff/


Testing
-------

Unit test done.
Manual test done.


Thanks,

Azrael Park

Reply via email to