----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23245/#review47308 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/service/ZKLocksService.java <https://reviews.apache.org/r/23245/#comment82971> nitpick: shouldn't this be LEADER_PATH? Can you also mention this path in the class javadoc comment? core/src/main/java/org/apache/oozie/service/ZKLocksService.java <https://reviews.apache.org/r/23245/#comment82969> nitpick: missing space before and after "/" core/src/main/resources/oozie-default.xml <https://reviews.apache.org/r/23245/#comment82970> Typo in threshlod (threshold) core/src/test/java/org/apache/oozie/service/TestZKLocksService.java <https://reviews.apache.org/r/23245/#comment82973> You can simply call getClient(), which is provided by ZKXTestCase. You then don't need to add the getZKUtils() method to ZKLocksService. pom.xml <https://reviews.apache.org/r/23245/#comment82968> Perhaps we should add a "curator.version" property (next to tomcat.version, openjpa.version, etc) so we only have to set it in one place? - Robert Kanter On July 2, 2014, 8:22 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23245/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 8:22 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1906 > https://issues.apache.org/jira/browse/OOZIE-1906 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1906 Service to periodically remove ZK lock > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java d03a899 > core/src/main/resources/oozie-default.xml 982c82f > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java a773469 > pom.xml bad1e0f > > Diff: https://reviews.apache.org/r/23245/diff/ > > > Testing > ------- > > UTC and manual testing. > > > Thanks, > > Purshotam Shah > >
