> On July 3, 2014, 6:59 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java, line 67 > > <https://reviews.apache.org/r/23245/diff/2/?file=622995#file622995line67> > > > > Shouldn't the mode be REAP_INDEFINITELY? REAP_UNTIL_DELETE will stop > > after the first deletion, right? > > > > > > https://curator.apache.org/apidocs/org/apache/curator/framework/recipes/locks/Reaper.Mode.html
REAP_INDEFINITELY:Reap forever, or until removePath is called for the path. I think this param is passed for each lock. REAP_INDEFINITELY is used as default implementation. Will use REAP_INDEFINITELY. - Purshotam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23245/#review47310 ----------------------------------------------------------- On July 2, 2014, 8:22 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23245/ > ----------------------------------------------------------- > > (Updated July 2, 2014, 8:22 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1906 > https://issues.apache.org/jira/browse/OOZIE-1906 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1906 Service to periodically remove ZK lock > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/ZKLocksService.java d03a899 > core/src/main/resources/oozie-default.xml 982c82f > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java a773469 > pom.xml bad1e0f > > Diff: https://reviews.apache.org/r/23245/diff/ > > > Testing > ------- > > UTC and manual testing. > > > Thanks, > > Purshotam Shah > >
