----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23345/#review47511 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/23345/#comment83416> This should not be a env variable. It should be a system property - oozie.connection.retry.count. client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/23345/#comment83418> getCLIParser client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/23345/#comment83454> Keep it package protected and not public client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/23345/#comment83419> setRetryCount client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/23345/#comment83456> Please separate and abstract this logic out to a ConnectionRetriableCommand something along the lines of org.apache.hadoop.tools.util.RetriableCommand and RetryHandler in org.apache.oozie.client.retry package. client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/23345/#comment83455> HttpURLConnection conn = createConnection(url, method); is the only line of code that should be in the retry logic. i,e URL url = createURL(protocolVersion, collection, resource, params); if (validateCommand(url.toString())) { if (getDebugMode() > 0) { System.out.println(method + " " + url); } HttpURLConnection conn = new ConnectionRetriableCommand(method) { @Override protected Object doExecute(final URL url, String method) throws Exception { HttpURLConnection conn = createConnection(url, method); return conn; } }.execute(url, method); return call(conn); docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/23345/#comment83423> ---+++ CLI Retry Oozie CLI retries connection to Oozie servers for transparent high availability failover when one of the Oozie servers go down. docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/23345/#comment83425> Remove exception after ConnectionException and SocketException. docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/23345/#comment83424> will have retry - Rohini Palaniswamy On July 8, 2014, 10:14 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23345/ > ----------------------------------------------------------- > > (Updated July 8, 2014, 10:14 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1914 > https://issues.apache.org/jira/browse/OOZIE-1914 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1914 CLI should retry on timeout > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3 > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 37ee256 > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java a8f8cf9 > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > > Diff: https://reviews.apache.org/r/23345/diff/ > > > Testing > ------- > > UTC and manual testing. > > > Thanks, > > Purshotam Shah > >
