----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23345/#review47798 -----------------------------------------------------------
client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/23345/#comment84008> oozie.connection.retry.count - java system property should be all lower case separated by . client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/23345/#comment84007> package private client/src/main/java/org/apache/oozie/cli/OozieCLI.java <https://reviews.apache.org/r/23345/#comment84006> setRetryCount client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/23345/#comment84005> Just put the retry in one place inside createConnection method client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java <https://reviews.apache.org/r/23345/#comment84004> retryCount instead of =oozie.connection.retry.count= as that property is not handled in this class client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java <https://reviews.apache.org/r/23345/#comment84009> Remove the debug mode and print at all times client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java <https://reviews.apache.org/r/23345/#comment84014> URL url as part of execute() instead of constructor client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java <https://reviews.apache.org/r/23345/#comment84013> Please rename variable to stopRetry or something. It is not exactly success when it is set to true. client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java <https://reviews.apache.org/r/23345/#comment84012> Extract this common code out to a method client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java <https://reviews.apache.org/r/23345/#comment84015> Remove debug mode and always throw this exception Number of retries client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java <https://reviews.apache.org/r/23345/#comment84010> System.err.println Connection exception has occurred [ " + e.getClass().getName() + " " + e.getMessage() ... - Rohini Palaniswamy On July 14, 2014, 11:20 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23345/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 11:20 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1914 > https://issues.apache.org/jira/browse/OOZIE-1914 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1914 CLI should retry on timeout > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3 > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > > client/src/main/java/org/apache/oozie/client/retry/ConnectionRetriableClient.java > e69de29 > core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 37ee256 > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java a8f8cf9 > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > > Diff: https://reviews.apache.org/r/23345/diff/ > > > Testing > ------- > > UTC and manual testing. > > > Thanks, > > Purshotam Shah > >
