[ 
https://issues.apache.org/jira/browse/OOZIE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082157#comment-14082157
 ] 

Rohini Palaniswamy commented on OOZIE-1939:
-------------------------------------------

[~chitnis],
     Can you just verify once that the logging fix you did for SLA works 
properly with the ThreadLocal parameters?  

[~shwethags],
     The idea of resetting prefix in beforeExecute() method of thread is really 
good and can be implemented in Oozie created threadpools. But you need to take 
into account that the tomcat thread pool also does processing - It submits job 
and invokes start action and any update change commands or executed in its 
threadpool. Can you check if there is a way we can automatically do that there 
too? If not we cannot get rid of code that resets prefix manually at the end of 
each command. 

> Incorrect job information is set while logging
> ----------------------------------------------
>
>                 Key: OOZIE-1939
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1939
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Purshotam Shah
>            Assignee: Azrael
>         Attachments: OOZIE-1939.1.patch, OOZIE-1939.2.patch
>
>
> {code}
> 2014-07-16 17:28:06,422 DEBUG CoordChangeXCommand:545 [http-0.0.0.0-4443-5] - 
> USER[hadoopqa] GROUP[users] TOKEN[] APP[coordB236] 
> JOB[0011514-140716042555-oozie-oozi-C] ACTION[-] Acquired lock for 
> [0011385-140716042555-oozie-oozi-C] in [coord_change]
> 2014-07-16 17:28:06,422 TRACE CoordChangeXCommand:548 [http-0.0.0.0-4443-5] - 
> USER[hadoopqa] GROUP[users] TOKEN[] APP[coordB236] 
> JOB[0011514-140716042555-oozie-oozi-C] ACTION[-] Load state for 
> [0011385-140716042555-oozie-oozi-C]
> {code}
> {code}
>     protected void loadState() throws CommandException {
>         jpaService = Services.get().get(JPAService.class);
>         if (jpaService == null) {
>             LOG.error(ErrorCode.E0610);
>         }
>         try {
>             coordJob = 
> CoordJobQueryExecutor.getInstance().get(CoordJobQuery.GET_COORD_JOB_MATERIALIZE,
>  jobId);
>             prevStatus = coordJob.getStatus();
>         }
>         catch (JPAExecutorException jex) {
>             throw new CommandException(jex);
>         }
>         // calculate start materialize and end materialize time
>         calcMatdTime();
>         LogUtils.setLogInfo(coordJob, logInfo);
>     }
> {code}
> Most of the commands set jobinfo after loadstate, because of that few log 
> statements ( like acquiring lock, load state) logs with previous jobinfo. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to