[ 
https://issues.apache.org/jira/browse/OOZIE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082478#comment-14082478
 ] 

Azrael commented on OOZIE-1939:
-------------------------------

If XCommand need the same log info across threads, why do we use the thread 
local log info in XCommand?
I think it is clear to use class level log info in XCommand and propagate the 
context for the other classes which use the thread local log info. 


> Incorrect job information is set while logging
> ----------------------------------------------
>
>                 Key: OOZIE-1939
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1939
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Purshotam Shah
>            Assignee: Azrael
>         Attachments: OOZIE-1939.1.patch, OOZIE-1939.2.patch
>
>
> {code}
> 2014-07-16 17:28:06,422 DEBUG CoordChangeXCommand:545 [http-0.0.0.0-4443-5] - 
> USER[hadoopqa] GROUP[users] TOKEN[] APP[coordB236] 
> JOB[0011514-140716042555-oozie-oozi-C] ACTION[-] Acquired lock for 
> [0011385-140716042555-oozie-oozi-C] in [coord_change]
> 2014-07-16 17:28:06,422 TRACE CoordChangeXCommand:548 [http-0.0.0.0-4443-5] - 
> USER[hadoopqa] GROUP[users] TOKEN[] APP[coordB236] 
> JOB[0011514-140716042555-oozie-oozi-C] ACTION[-] Load state for 
> [0011385-140716042555-oozie-oozi-C]
> {code}
> {code}
>     protected void loadState() throws CommandException {
>         jpaService = Services.get().get(JPAService.class);
>         if (jpaService == null) {
>             LOG.error(ErrorCode.E0610);
>         }
>         try {
>             coordJob = 
> CoordJobQueryExecutor.getInstance().get(CoordJobQuery.GET_COORD_JOB_MATERIALIZE,
>  jobId);
>             prevStatus = coordJob.getStatus();
>         }
>         catch (JPAExecutorException jex) {
>             throw new CommandException(jex);
>         }
>         // calculate start materialize and end materialize time
>         calcMatdTime();
>         LogUtils.setLogInfo(coordJob, logInfo);
>     }
> {code}
> Most of the commands set jobinfo after loadstate, because of that few log 
> statements ( like acquiring lock, load state) logs with previous jobinfo. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to