[ 
https://issues.apache.org/jira/browse/OOZIE-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14111139#comment-14111139
 ] 

Robert Kanter commented on OOZIE-1830:
--------------------------------------

We're having a lot of issues with the test build servers right now (hence the 
multiple posts by Hadoop QA); so I'll probably run all tests locally before 
committing it.  

But before that, I have some comments on the latest patch:
- In the hadoop-X profiles in the client pom, you've set them to be activated 
on the {{hadoop.version}} variable.  I don't think that's necessary because we 
currently expect the user to explicitly set a profile to be activated (i.e. 
{{mvn whatever -Phadoop-2}}).  So I think you can remove that activation 
property.  (See how we have them defined in the root pom).
-- Though maybe you do have to do this for the "hadoop-1" profile...
- In the root pom, we default the {{hadoop.auth.version}} property to 
{{2.0.2-alpha}}.  I think you can remove that now.
- What does the {{hadoop-auth-default}} profile in the client pom do?
- Also, don't forget to do {{--no-prefix}} when generating the patch so you 
don't get paths prepended with "a" and "b" :)

> Change hadoop-1 profile to use 1.2.1
> ------------------------------------
>
>                 Key: OOZIE-1830
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1830
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk, 4.0.1
>            Reporter: Azrael
>            Priority: Minor
>         Attachments: OOZIE-1830.1.patch, OOZIE-1830.2.patch, 
> OOZIE-1830.3.patch, OOZIE-1830.4.patch, OOZIE-1830.5.patch
>
>
> We should change the hadoop-1 profile to use 1.2.1 instead of 1.1.1.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to