[ 
https://issues.apache.org/jira/browse/OOZIE-1830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14112716#comment-14112716
 ] 

Azrael commented on OOZIE-1830:
-------------------------------

Thanks for review and comments. It's really helpful.

{quote}
In the hadoop-X profiles in the client pom, you've set them to be activated on 
the hadoop.version variable. I don't think that's necessary because we 
currently expect the user to explicitly set a profile to be activated 
{quote}
This is because of the {{-Dhadoop.version=}} option. {{mkdistro.sh 
-Dhadoop.version=2.x.x}} should pass.

{quote}
What does the hadoop-auth-default profile in the client pom do?
{quote}
{{hadoop-auth-default}} profile is for the case when no hadoop.version option 
set, i.e {{mkdistro.sh}}.
However, this patch doesn't solve the problem(my bad, I missed {{-P}} profile 
set). 
{{mkdisto.sh -Phadoop-2}} does not work.

{quote}
Though maybe you do have to do this for the "hadoop-1" profile...
{quote}
If we create hadoop-1 profile, build always need hadoop-x profile.

So, build should succeed on following conditions:
# mkdistro.sh : default hadoop.version property in the pom
# mkdistro.sh -Dhadoop.version=xxx : explicit hadoop version option
# mkdistro.sh -Phadoop-X : explicit hadoop profile (though this is not 
mentioned in document)

Currently, we use optional hadoop dependency by separate module based on 
hadoop.version property.
IMO, hadoop-auth dependency should be in separate module {{oozie-hadoop-auth}}.
I revised v3.patch and upload as v6.patch.
Sorry for the messy stuff and expect your comment :).

> Change hadoop-1 profile to use 1.2.1
> ------------------------------------
>
>                 Key: OOZIE-1830
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1830
>             Project: Oozie
>          Issue Type: Improvement
>    Affects Versions: trunk, 4.0.1
>            Reporter: Azrael
>            Priority: Minor
>         Attachments: OOZIE-1830.1.patch, OOZIE-1830.2.patch, 
> OOZIE-1830.3.patch, OOZIE-1830.4.patch, OOZIE-1830.5.patch, OOZIE-1830.6.patch
>
>
> We should change the hadoop-1 profile to use 1.2.1 instead of 1.1.1.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to