> On Aug. 29, 2014, 4:52 p.m., Purshotam Shah wrote: > > client/src/main/java/org/apache/oozie/client/OozieClient.java, line 152 > > <https://reviews.apache.org/r/24487/diff/2/?file=660982#file660982line152> > > > > Do you need to say new (newshouldend ) ? > > > > When we specify end time for coord, we just say endtime=<>, better to > > keep same convention.
Its consistent with the current SLA terminology - should-start, should-end. I dont see the major benefit of deviating from this terminology. Also endtime=<> and should-end are dealing with different values, former specifies date and latter specifies the number of minutes relative to a nominal time for sla purposes. > On Aug. 29, 2014, 4:52 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java, > > line 91 > > <https://reviews.apache.org/r/24487/diff/2/?file=660987#file660987line91> > > > > We are reading from same conf and setting to same conf. why?? dont remember the rationale now. removing - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24487/#review51473 ----------------------------------------------------------- On Aug. 14, 2014, 11:13 p.m., Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24487/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2014, 11:13 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1913 > https://issues.apache.org/jira/browse/OOZIE-1913 > > > Repository: oozie-git > > > Description > ------- > > See Jira > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 33935d3 > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > > client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 2f0a45c > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 5d3fc62 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java 795bf63 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 8fd53f1 > core/src/main/java/org/apache/oozie/command/SubmitTransitionXCommand.java > 5d3b6af > > core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java > ffb2d08 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > b4b2fef > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 02b30ef > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 26db068 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > cd26e07 > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 42a0968 > core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java 8296a6c > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > 3fbd092 > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8ca2e81 > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java 8620af5 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 67d6237 > core/src/main/java/org/apache/oozie/sla/SLACalculator.java 132d4df > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java 3801325 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java 0cad071 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java 2349329 > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > fd21c45 > core/src/main/resources/oozie-default.xml ebceaa7 > core/src/test/java/org/apache/oozie/client/TestWorkflowClient.java e2e0f11 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > fedf4a8 > core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java a39efe3 > core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > fa26935 > core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5a35fdb > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > 210c99e > > Diff: https://reviews.apache.org/r/24487/diff/ > > > Testing > ------- > > unit tests added, e-2-e test with CLI command done > > > Thanks, > > Mona Chitnis > >
