> On Sept. 8, 2014, 6:50 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/util/Pair.java, line 73 > > <https://reviews.apache.org/r/24299/diff/4/?file=682415#file682415line73> > > > > 1. > > If first!=null and otherPair.first=null > > second=null and otherPair.second=null. > > > > Then this will return true. > > 2. > > If first=abc and otherPair.first=xyz > > second=null and otherPair.second=null. > > > > Then this will return true. > > > > Is this ok?
I copied this from Hive.Pair and assumed that they must have written it right and didn't check. Yes, this will not work. Will fix - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review52619 ----------------------------------------------------------- On Sept. 8, 2014, 6:15 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24299/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2014, 6:15 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1950 > https://issues.apache.org/jira/browse/OOZIE-1950 > > > Repository: oozie-git > > > Description > ------- > > Adds filter on nominal time in get coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java 363ebd2 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 249ae68 > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 4d5ba71 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > cdd5000 > core/src/main/java/org/apache/oozie/util/Pair.java PRE-CREATION > core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java 93c9235 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java > 824eb80 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > d3d29aa > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > > Diff: https://reviews.apache.org/r/24299/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > >
