> On Aug. 29, 2014, 7:14 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 36 > > <https://reviews.apache.org/r/24299/diff/3/?file=664212#file664212line36> > > > > [INFO] | | +- org.apache.commons:commons-lang3:jar:3.1:provided > > can you please check about commons-lang3, I don't think it's a part of > > oozie-webapp.
Didn't find anything useful in the existing libs. So, will add Pair class in oozie > On Aug. 29, 2014, 7:14 p.m., Purshotam Shah wrote: > > core/src/main/java/org/apache/oozie/CoordinatorEngine.java, line 640 > > <https://reviews.apache.org/r/24299/diff/3/?file=664212#file664212line640> > > > > "elements must be name=value or name!=value pairs"); > > > > Minor.. Can you please support throwing error if status is not in > > format name=value or name!=value. Will do - shwethags ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24299/#review51896 ----------------------------------------------------------- On Aug. 19, 2014, 8:37 a.m., shwethags wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24299/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 8:37 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1950 > https://issues.apache.org/jira/browse/OOZIE-1950 > > > Repository: oozie-git > > > Description > ------- > > Adds filter on nominal time in get coord actions > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java b468186 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java dd5c703 > core/src/main/java/org/apache/oozie/command/coord/CoordJobXCommand.java > 5eaf062 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobGetActionsSubsetJPAExecutor.java > a531798 > core/src/test/java/org/apache/oozie/TestCoordinatorEngine.java e3db675 > core/src/test/java/org/apache/oozie/TestCoordinatorEngineSimple.java > 1904519 > > core/src/test/java/org/apache/oozie/executor/jpa/TestCoordJobGetActionsSubsetJPAExecutor.java > 147bdb7 > docs/src/site/twiki/DG_CommandLineTool.twiki 4a07711 > > Diff: https://reviews.apache.org/r/24299/diff/ > > > Testing > ------- > > UTs > > > Thanks, > > shwethags > >
