----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28842/#review68784 -----------------------------------------------------------
Review for Page 2 core/src/main/java/org/apache/oozie/command/coord/CoordSlaAlertsXCommand.java <https://reviews.apache.org/r/28842/#comment113226> Why is this required and why do we get list of actions? core/src/main/java/org/apache/oozie/command/coord/CoordSlaAlertsXCommand.java <https://reviews.apache.org/r/28842/#comment113225> Can you move this method to CoordUtils? core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113224> getCoordActionIds core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113222> isSLAAlertDisabled core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113223> SLA_DISABLE_ALERT_OLDER_THAN core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113227> SLA_DISABLE_ALERT core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113228> What about ids? core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113229> Search for suspend and rename to disabled everywhere core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113230> getCoordActionSLAAlertStatus core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113231> why is this block required? Is this not being checked in the first block in the method? core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113232> slaAlertConfig core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113233> could be enable as well core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113235> value : values core/src/main/java/org/apache/oozie/coord/CoordUtils.java <https://reviews.apache.org/r/28842/#comment113234> what if it was not action range and just actions? For eg: 1,5,7 core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java <https://reviews.apache.org/r/28842/#comment113245> What is this for and why is it needed? core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java <https://reviews.apache.org/r/28842/#comment113247> v0. In other methods as well core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java <https://reviews.apache.org/r/28842/#comment113252> LASLARegistrationMap -> slaConfigMap core/src/main/java/org/apache/oozie/sla/SLACalculator.java <https://reviews.apache.org/r/28842/#comment113254> Map<String, String> newParams - Please use the exact method parameters instead of passing a map core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/28842/#comment113257> Can you extract this code to a private method? It is repeated multiple times throughout. core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/28842/#comment113255> This is an unnecessary update. Should be only done when there is a change. core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/28842/#comment113261> enableAlert(List<String> jobIds, List<String> parentIds) Same for other methods core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java <https://reviews.apache.org/r/28842/#comment113237> GET_SLA_CONFIG core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java <https://reviews.apache.org/r/28842/#comment113264> slaConfigMap core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java <https://reviews.apache.org/r/28842/#comment113262> Disabled , Enabled - Rohini Palaniswamy On Jan. 15, 2015, 2:01 a.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28842/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 2:01 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1913 > https://issues.apache.org/jira/browse/OOZIE-1913 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1913 Devise a way to turn off SLA alerts for bundle/coordinator flexibly > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc8fa50 > client/src/main/java/org/apache/oozie/client/OozieClient.java 800e871 > > client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 801ad7e > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java b7cf0e7 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 85efecf > core/src/main/java/org/apache/oozie/BaseEngine.java a982ad4 > core/src/main/java/org/apache/oozie/BundleEngine.java 27afe73 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3406c6f > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 4d6b970 > core/src/main/java/org/apache/oozie/DagEngine.java 70ddd44 > core/src/main/java/org/apache/oozie/ErrorCode.java 4444c87 > core/src/main/java/org/apache/oozie/command/SlaAlertsXCommand.java e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleChangeSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleDisableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleEnableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordDisableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordEnableSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 548946f > > core/src/main/java/org/apache/oozie/command/coord/CoordSlaAlertsXCommand.java > e69de29 > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73 > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 4bccef4 > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e220c01 > > core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > c3197b7 > core/src/main/java/org/apache/oozie/jms/JMSSLAEventListener.java c19839f > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > fa16d1d > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 7c0d3be > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java c94d1e2 > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java b160b46 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java eed7ca1 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java da81b49 > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java a0fe1b6 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea > core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java fdce6b5 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826 > core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 0770bd3 > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 9907dd0 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java a4562e7 > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 7c2620c > core/src/main/resources/oozie-default.xml e849fc7 > core/src/test/java/org/apache/oozie/command/TestSlaAlertCommand.java > e69de29 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 5ce9a7f > core/src/test/java/org/apache/oozie/coord/TestCoordUtils.java ae3f18d > core/src/test/java/org/apache/oozie/jms/TestJMSSLAEventListener.java > 30fd151 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > c70ef79 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java ea82baa > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > fe9002c > core/src/test/resources/coord-action-sla.xml 8b301fd > docs/src/site/twiki/DG_CommandLineTool.twiki 4ac73f9 > webapp/src/main/webapp/console/sla/js/oozie-sla-table.js 1a88671 > webapp/src/main/webapp/console/sla/oozie-sla.html 23e8af2 > > Diff: https://reviews.apache.org/r/28842/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
