----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28842/#review69707 -----------------------------------------------------------
There is still a "suspend" instead of disable in DG_CommandLineTool.twiki client/src/main/java/org/apache/oozie/client/OozieClient.java <https://reviews.apache.org/r/28842/#comment115103> Change SLA definition of a coordinator SLA change definition parameters can be.. Supported parameter key names are ... Change to be done on the overloaded method as well. core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java <https://reviews.apache.org/r/28842/#comment115119> Once changed, don't you have to reload the changed values in memory? For eg: If expected endtime was changed from 30mins after nominal time to 10 mins after nominal time, an alert would not be sent at 11th min as memory still has 30 mins and is checking against that. core/src/main/java/org/apache/oozie/sla/SLAOperations.java <https://reviews.apache.org/r/28842/#comment115122> add instead of ddd core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java <https://reviews.apache.org/r/28842/#comment114430> To be removed docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment115130> Changing job SLA definition and alerting You need to define a anchor tag #JobSLACommand here to actually reference it from other pages. For eg, refer #HCatPigExampleOne in CoordinatorFunctionSpec twiki. docs/src/site/twiki/DG_CommandLineTool.twiki <https://reviews.apache.org/r/28842/#comment115125> actions core/src/main/java/org/apache/oozie/CoordinatorActionBean.java <https://reviews.apache.org/r/28842/#comment115108> Can the queries be re-written to say a.statusStr in ('PREP','RUNNING',......) so that the status index will be used. core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsEnableXCommand.java <https://reviews.apache.org/r/28842/#comment115114> SLA.alerts.enable/disable docs/src/site/twiki/DG_SLAMonitoring.twiki <https://reviews.apache.org/r/28842/#comment115126> Changing job SLA definition and alerting docs/src/site/twiki/DG_SLAMonitoring.twiki <https://reviews.apache.org/r/28842/#comment115129> SLA alert status can also be modified through commandline or REST API after submission for running jobs. Refer [[DG_CommandLineTool#JobSLACommand][job -sla command]] for commandline usage. Refer the REST API [[..][here]]. SLA definition of should-start, should-end, nominal-time and max-duration can be changed for running jobs through commandline or REST API. Refer [[DG_CommandLineTool#JobSLACommand][job -sla command]] for commandline usage. Refer the REST API [[..][here]]. docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/28842/#comment115132> Changing job SLA definition and alerting docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/28842/#comment115133> Need to document all key options docs/src/site/twiki/WebServicesAPI.twiki <https://reviews.apache.org/r/28842/#comment115134> Need to document date and coordinator options for bundle. - Rohini Palaniswamy On Jan. 26, 2015, 11:14 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28842/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 11:14 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-1913 > https://issues.apache.org/jira/browse/OOZIE-1913 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1913 Devise a way to turn off SLA alerts for bundle/coordinator flexibly > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java bc8fa50 > client/src/main/java/org/apache/oozie/client/OozieClient.java 800e871 > > client/src/main/java/org/apache/oozie/client/event/jms/JMSHeaderConstants.java > 801ad7e > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java b7cf0e7 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 85efecf > core/src/main/java/org/apache/oozie/BaseEngine.java a982ad4 > core/src/main/java/org/apache/oozie/BundleEngine.java 27afe73 > core/src/main/java/org/apache/oozie/CoordinatorActionBean.java bd01d14 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 3406c6f > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java 4d6b970 > core/src/main/java/org/apache/oozie/DagEngine.java 70ddd44 > core/src/main/java/org/apache/oozie/ErrorCode.java 4444c87 > core/src/main/java/org/apache/oozie/command/SlaAlertsXCommand.java e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSLAAlertsDisableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSLAAlertsEnableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSLAChangeXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/bundle/BundleSlaAlertsXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 548946f > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsDisableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAAlertsEnableXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordSLAChangeXCommand.java > e69de29 > > core/src/main/java/org/apache/oozie/command/coord/CoordSlaAlertsXCommand.java > e69de29 > core/src/main/java/org/apache/oozie/coord/CoordUtils.java 4643d73 > > core/src/main/java/org/apache/oozie/executor/jpa/CoordActionQueryExecutor.java > e6ab09b > core/src/main/java/org/apache/oozie/executor/jpa/CoordJobQueryExecutor.java > 4bccef4 > > core/src/main/java/org/apache/oozie/executor/jpa/SLARegistrationQueryExecutor.java > e220c01 > > core/src/main/java/org/apache/oozie/executor/jpa/SLASummaryQueryExecutor.java > c3197b7 > > core/src/main/java/org/apache/oozie/service/CoordMaterializeTriggerService.java > fa16d1d > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 7c0d3be > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java c94d1e2 > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 2578e41 > core/src/main/java/org/apache/oozie/servlet/V0JobServlet.java b160b46 > core/src/main/java/org/apache/oozie/servlet/V1JobServlet.java eed7ca1 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java da81b49 > core/src/main/java/org/apache/oozie/servlet/V2SLAServlet.java a0fe1b6 > core/src/main/java/org/apache/oozie/sla/SLACalcStatus.java 189d5ea > core/src/main/java/org/apache/oozie/sla/SLACalculator.java 20f93b5 > core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java fdce6b5 > core/src/main/java/org/apache/oozie/sla/SLAOperations.java f5fc826 > core/src/main/java/org/apache/oozie/sla/SLARegistrationBean.java 0770bd3 > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 9907dd0 > core/src/main/java/org/apache/oozie/sla/service/SLAService.java a4562e7 > core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java > 7c2620c > core/src/main/resources/oozie-default.xml e849fc7 > core/src/test/java/org/apache/oozie/command/TestSlaAlertCommand.java > e69de29 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > 5ce9a7f > core/src/test/java/org/apache/oozie/servlet/TestV2SLAServlet.java 5f51b22 > core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java > c70ef79 > core/src/test/java/org/apache/oozie/sla/TestSLAEventGeneration.java ea82baa > > core/src/test/java/org/apache/oozie/sla/TestSLARegistrationGetJPAExecutor.java > fe9002c > core/src/test/resources/coord-action-sla.xml 8b301fd > docs/src/site/twiki/DG_CommandLineTool.twiki 4ac73f9 > docs/src/site/twiki/DG_SLAMonitoring.twiki acf8ac1 > docs/src/site/twiki/WebServicesAPI.twiki fc51934 > webapp/src/main/webapp/console/sla/js/oozie-sla-table.js 1a88671 > webapp/src/main/webapp/console/sla/oozie-sla.html 23e8af2 > > Diff: https://reviews.apache.org/r/28842/diff/ > > > Testing > ------- > > UTC > > > Thanks, > > Purshotam Shah > >
