> On June 4, 2015, 5:33 a.m., Srikanth Sundarrajan wrote: > > core/src/main/java/org/apache/oozie/service/PopulatorMetricsReportingManager.java, > > line 92 > > <https://reviews.apache.org/r/34854/diff/2/?file=975102#file975102line92> > > > > Is it required to publish using report() more periodically? If so where > > is this being done ?
The time can configured during runtime by setting the parameter "oozie.metrics.report.interval.sec" in oozie-site.xml > On June 4, 2015, 5:33 a.m., Srikanth Sundarrajan wrote: > > core/src/main/java/org/apache/oozie/service/PopulatorMetricsReportingManager.java, > > line 68 > > <https://reviews.apache.org/r/34854/diff/2/?file=975102#file975102line68> > > > > Can this not throw checked exception ? If we throw checked exception, then it has to be handled at all the parent classes. Suggest me any better way if you know. > On June 4, 2015, 5:33 a.m., Srikanth Sundarrajan wrote: > > core/src/main/java/org/apache/oozie/util/Instrumentation.java, line 56 > > <https://reviews.apache.org/r/34854/diff/2/?file=975103#file975103line56> > > > > Should this be in Insturmentation or InstrumentationService. > > > > I also dont see PopulatorMetricsReportingManager::stop() actually > > called unless manager's life cycle is wired up to a service The life-time of the metrics reporter is the entire lifetime of the oozie server. So, it will be stopped automatically when the oozie server stops. So, we have no particular of stop method here. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34854/#review86550 ----------------------------------------------------------- On June 4, 2015, 6:02 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34854/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 6:02 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2251 > https://issues.apache.org/jira/browse/OOZIE-2251 > > > Repository: oozie-git > > > Description > ------- > > We have been logging so many important matrices in oozie-instrumentation.log > . These information is very useful for oozie functional monitoring. But it is > always difficult to get the meaning from flat file. If we expose this > information on some graphing tool, We can get the lot of meaning out of it > and can take some actions based on it. > > > Diffs > ----- > > core/pom.xml 7877773 > > core/src/main/java/org/apache/oozie/service/PopulatorMetricsReportingManager.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/Instrumentation.java 3dfb67a > core/src/main/java/org/apache/oozie/util/OozieMonitoringComponent.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 8960073 > > Diff: https://reviews.apache.org/r/34854/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
