----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34854/#review87703 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java <https://reviews.apache.org/r/34854/#comment140121> make this is a non-static func core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java <https://reviews.apache.org/r/34854/#comment140120> why add this as a static method. instead do instrumentation.stop(); before instrumentation = null; - Srikanth Sundarrajan On June 12, 2015, 10:04 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34854/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 10:04 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2251 > https://issues.apache.org/jira/browse/OOZIE-2251 > > > Repository: oozie-git > > > Description > ------- > > We have been logging so many important matrices in oozie-instrumentation.log > . These information is very useful for oozie functional monitoring. But it is > always difficult to get the meaning from flat file. If we expose this > information on some graphing tool, We can get the lot of meaning out of it > and can take some actions based on it. > > > Diffs > ----- > > core/pom.xml 7877773 > > core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java > 29f6294 > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > e56bfda > core/src/main/resources/oozie-default.xml 8960073 > docs/src/site/twiki/AG_Install.twiki 0ce2609 > > Diff: https://reviews.apache.org/r/34854/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
