----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35340/#review87765 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java <https://reviews.apache.org/r/35340/#comment140183> This method does not seem to be called from anywhere core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java <https://reviews.apache.org/r/35340/#comment140184> Wouldn't it be more performant to parse each of the jobxml once and store them in Map<jobmxlpath, Configuration> so that we don't parse them again for each action? - Rohini Palaniswamy On June 11, 2015, 2:10 a.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35340/ > ----------------------------------------------------------- > > (Updated June 11, 2015, 2:10 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2187 > https://issues.apache.org/jira/browse/OOZIE-2187 > > > Repository: oozie-git > > > Description > ------- > > See this comment: > https://issues.apache.org/jira/browse/OOZIE-2187?focusedCommentId=14522592&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14522592 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/ActionExecutor.java ea652f3 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 7a7d4a7 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > c857011 > core/src/main/resources/oozie-default.xml 8960073 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 0eb1ee0 > core/src/test/resources/wf-schema-no-jobtracker-global.xml PRE-CREATION > core/src/test/resources/wf-schema-no-jobtracker.xml PRE-CREATION > core/src/test/resources/wf-schema-no-namenode-global.xml PRE-CREATION > core/src/test/resources/wf-schema-no-namenode.xml PRE-CREATION > core/src/test/resources/wf-schema-valid-global-ext.xml 86d274d > > Diff: https://reviews.apache.org/r/35340/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
