> On June 12, 2015, 10:16 p.m., Rohini Palaniswamy wrote: > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java, > > line 638 > > <https://reviews.apache.org/r/35340/diff/1/?file=982401#file982401line638> > > > > Wouldn't it be more performant to parse each of the jobxml once and > > store them in Map<jobmxlpath, Configuration> so that we don't parse them > > again for each action? > > Robert Kanter wrote: > The code here is simply adding a <job-xml> in the action, without > actually parsing the referenced file; that's done later in the > ActionExecutor. > > If we want to parse <job-xml> here instead, I think that should be saved > for another JIRA; we'd have to think about if we actually want to do this > because it will have other reprecussions (e.g. it will take up more space in > the database).
Sounds good. +1 from my side. Jaydeep had some minor comments on using static string for job-xml and formatting. Will +1 here and in the jira after that is addressed. - Rohini ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35340/#review87765 ----------------------------------------------------------- On June 23, 2015, 8:58 p.m., Robert Kanter wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35340/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 8:58 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2187 > https://issues.apache.org/jira/browse/OOZIE-2187 > > > Repository: oozie-git > > > Description > ------- > > See this comment: > https://issues.apache.org/jira/browse/OOZIE-2187?focusedCommentId=14522592&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14522592 > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/ActionExecutor.java 07c6d26 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 492ceaf > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > c857011 > core/src/main/resources/oozie-default.xml 4dc127e > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 0eb1ee0 > core/src/test/resources/wf-schema-no-jobtracker-global.xml PRE-CREATION > core/src/test/resources/wf-schema-no-jobtracker.xml PRE-CREATION > core/src/test/resources/wf-schema-no-namenode-global.xml PRE-CREATION > core/src/test/resources/wf-schema-no-namenode.xml PRE-CREATION > core/src/test/resources/wf-schema-valid-global-ext.xml 86d274d > > Diff: https://reviews.apache.org/r/35340/diff/ > > > Testing > ------- > > > Thanks, > > Robert Kanter > >
