> On June 15, 2015, 6:25 a.m., Shwetha GS wrote: > > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java, line > > 98 > > <https://reviews.apache.org/r/34854/diff/7/?file=983898#file983898line98> > > > > prefix all related configs with 'oozie.external_monitoring.'. For > > example, change oozie.metrics.report.interval.sec - > > oozie.external_monitoring.reporterIntervalSecs > > oozie.metrics.host - oozie.external_monitoring.address (covers both > > host and port so that there are less configs that users need to set) > > oozie.metrics.server.name - oozie.external_monitoring.type > > oozie.metrics.prefix - oozie.external_monitoring.metricPrefix > > > > Use . for hierarchical configs, not as word separator > > Narayan Periwal wrote: > When we initialize the graphite object, there we need to pass the host > and the port separately to make the InetSocketAddress object. So, to avoid > the parsing, I am keeping the host and the port as separate configs. Also, > now the user cannot fail to give the port number. > > Narayan Periwal wrote: > Please let me know if you have some other suggestion
For the function, you can use URL and get host and port. We should minimise the number of configs that users have to set. now the user cannot fail to give the port number - why can't they skip setting another config? Both graphite and ganglia servers have different default ports than the default that you have set. - Shwetha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34854/#review87894 ----------------------------------------------------------- On June 12, 2015, 7:53 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34854/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 7:53 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2251 > https://issues.apache.org/jira/browse/OOZIE-2251 > > > Repository: oozie-git > > > Description > ------- > > We have been logging so many important matrices in oozie-instrumentation.log > . These information is very useful for oozie functional monitoring. But it is > always difficult to get the meaning from flat file. If we expose this > information on some graphing tool, We can get the lot of meaning out of it > and can take some actions based on it. > > > Diffs > ----- > > core/pom.xml 7877773 > > core/src/main/java/org/apache/oozie/service/MetricsInstrumentationService.java > 29f6294 > core/src/main/java/org/apache/oozie/util/Instrumentation.java 3dfb67a > core/src/main/java/org/apache/oozie/util/MetricsInstrumentation.java > e56bfda > core/src/main/resources/oozie-default.xml 8960073 > docs/src/site/twiki/AG_Install.twiki 0ce2609 > > Diff: https://reviews.apache.org/r/34854/diff/ > > > Testing > ------- > > Done > > > Thanks, > > Narayan Periwal > >
