> On Nov. 30, 2015, 5:06 a.m., Rohini Palaniswamy wrote: > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java, > > line 709 > > <https://reviews.apache.org/r/35379/diff/7/?file=1017730#file1017730line709> > > > > Shouldn't foo3 be actionconf here also?
No it will be foo3 only and it is independent to this patch. Configuration tag has no code to merge with action conf. But both are independently exists in some form to use. In Action executor actionconf have "foo3=foo3" and configuration conf "foo3=actionconf" can be access through context.getworkflow.getConf/context.getprotoconf , And for same reason I have mentioned that value in test case. I will fix it as separate patch as it has no relation with global conf. - Jaydeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35379/#review108278 ----------------------------------------------------------- On Nov. 30, 2015, 7:50 p.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35379/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 7:50 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2030 > https://issues.apache.org/jira/browse/OOZIE-2030 > > > Repository: oozie-git > > > Description > ------- > > Forwarding global conf from workflow to action when action is subworkflow, > subworkflow storing it to property and forwarding as property. > LiteworkflowAppParser handling all condition and ensuring child level pass > of global conf. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 854d621 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > d3a6523 > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > 9ab897a > > Diff: https://reviews.apache.org/r/35379/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Jaydeep Vishwakarma > >
