----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35379/#review108386 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 506) <https://reviews.apache.org/r/35379/#comment167828> This line should be removed. core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (lines 518 - 520) <https://reviews.apache.org/r/35379/#comment167827> This block is not required as it is being set only when propagate-configuration is true. core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 109) <https://reviews.apache.org/r/35379/#comment167831> oozie.wf.globalconf core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 508) <https://reviews.apache.org/r/35379/#comment167834> if(jobConf.get(OOZIE_GLOBAL) != null) { gData = getGlobalFromString(jobConf.get(OOZIE_GLOBAL)); handleDefaultsAndGlobal(gData, null, eNode); } core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (line 673) <https://reviews.apache.org/r/35379/#comment167833> writeUTF(null) core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java (lines 736 - 739) <https://reviews.apache.org/r/35379/#comment167832> This needs to be removed and GlobalSectionData gData passed as method parameter to avoid deserializing for every action. - Rohini Palaniswamy On Nov. 30, 2015, 7:50 p.m., Jaydeep Vishwakarma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35379/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 7:50 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2030 > https://issues.apache.org/jira/browse/OOZIE-2030 > > > Repository: oozie-git > > > Description > ------- > > Forwarding global conf from workflow to action when action is subworkflow, > subworkflow storing it to property and forwarding as property. > LiteworkflowAppParser handling all condition and ensuring child level pass > of global conf. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/action/oozie/SubWorkflowActionExecutor.java > 854d621 > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > d3a6523 > > core/src/test/java/org/apache/oozie/action/oozie/TestSubWorkflowActionExecutor.java > 9ab897a > > Diff: https://reviews.apache.org/r/35379/diff/ > > > Testing > ------- > > yes > > > Thanks, > > Jaydeep Vishwakarma > >
