[
https://issues.apache.org/jira/browse/OOZIE-2411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15039172#comment-15039172
]
Robert Kanter commented on OOZIE-2411:
--------------------------------------
The new patch looks good. Thanks for adding the checks for other fields.
Just two minor things and I think it will be ready to go:
# The license header should be left as-is. We actually use a tool that checks
all of the headers and they're currently all correct.
# Can you move each of the {{Pattern.compile}} into {{private static final}}
class variables? This way we only have to compile each of them once. For
example:
{code:java}
private static final Pattern CHECK_SUBJECT_PATTERN =
Pattern.compile("Subject:[^:]*sub");
{code}
> Add BCC to oozie email action
> -----------------------------
>
> Key: OOZIE-2411
> URL: https://issues.apache.org/jira/browse/OOZIE-2411
> Project: Oozie
> Issue Type: New Feature
> Components: action, docs, tests
> Affects Versions: 4.2.0
> Reporter: Ferenc Denes
> Assignee: Ferenc Denes
> Labels: newbie
> Attachments: OOZIE-2411-1.patch, OOZIE-2411-2.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The Oozie e-mail action support To: and CC:
> A request has been made to add support for BCC: as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
