[
https://issues.apache.org/jira/browse/OOZIE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292321#comment-15292321
]
Robert Kanter commented on OOZIE-2532:
--------------------------------------
I think this would be a helpful change. We occasionally have the need for
binary files.
While we're here, it would be nice if it could accept both {{p0}} and {{p1}}
patches. This often trips up new contributors. It's also annoying because
ReviewBoard requires {{p1}}, but here we're requiring {{p0}}, so if you're
using RB, you have to generate the patch twice. I don't think there's a
convenient argument for this though :(
> patch apply does not handle binary files
> ----------------------------------------
>
> Key: OOZIE-2532
> URL: https://issues.apache.org/jira/browse/OOZIE-2532
> Project: Oozie
> Issue Type: Task
> Reporter: Peter Cseh
> Assignee: Peter Cseh
> Attachments: OOZIE-2532-001.patch
>
>
> In OOZIE-2482 there is a patch which contains binary files as well.
> After running
> {quote}patch -E -p0 <~/Downloads/OOZIE-2482-2.patch {quote}
> the folder sharelib/spark/src/test/resources contains only pi.py, and not the
> zip files.
> {quote}git apply -p0 <~/Downloads/OOZIE-2482-2.patch {quote}
> processes the binary part of the patch as well.
> Git documentation claims that patches created with --binary can be applied
> with git apply, I assume they know that it's not compatible with the patch
> command.
> Should we change this in the Jenkins job or we should keep this behavior as a
> gatekeeper to prevent binary files committed to master?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
