[
https://issues.apache.org/jira/browse/OOZIE-2532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292591#comment-15292591
]
Hadoop QA commented on OOZIE-2532:
----------------------------------
Testing JIRA OOZIE-2532
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color}
. Tests run: 1780
. Tests failed: 5
. Tests errors: 2
. The patch failed the following testcases:
. testMain(org.apache.oozie.action.hadoop.TestHiveMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMain)
. testPig_withNullExternalID(org.apache.oozie.action.hadoop.TestPigMain)
. testEmbeddedPigWithinPython(org.apache.oozie.action.hadoop.TestPigMain)
. testPigScript(org.apache.oozie.action.hadoop.TestPigMainWithOldAPI)
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/2890/
> patch apply does not handle binary files
> ----------------------------------------
>
> Key: OOZIE-2532
> URL: https://issues.apache.org/jira/browse/OOZIE-2532
> Project: Oozie
> Issue Type: Task
> Reporter: Peter Cseh
> Assignee: Peter Cseh
> Attachments: OOZIE-2532-001.patch, OOZIE-2532-002.patch
>
>
> In OOZIE-2482 there is a patch which contains binary files as well.
> After running
> {quote}patch -E -p0 <~/Downloads/OOZIE-2482-2.patch {quote}
> the folder sharelib/spark/src/test/resources contains only pi.py, and not the
> zip files.
> {quote}git apply -p0 <~/Downloads/OOZIE-2482-2.patch {quote}
> processes the binary part of the patch as well.
> Git documentation claims that patches created with --binary can be applied
> with git apply, I assume they know that it's not compatible with the patch
> command.
> Should we change this in the Jenkins job or we should keep this behavior as a
> gatekeeper to prevent binary files committed to master?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
