----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48149/#review136504 -----------------------------------------------------------
Appendix needs to have schema updated docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (lines 3164 - 3165) <https://reviews.apache.org/r/48149/#comment201559> expression will evaluate to true docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3166) <https://reviews.apache.org/r/48149/#comment201561> With combine, instances of A and B can be interleaved to get the final "combined" set of total instances. All datasets in combine should have the same range defined with the current EL function. Combine does not support latest and future EL functions. Combine cannot also be nested. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (lines 3168 - 3170) <https://reviews.apache.org/r/48149/#comment201643> Just do plain paragraphs. The conditional logic has to be specified using the <input-logic> tag in the coordinator.xml. If not specified, the default behavior of "AND" of all defined input dependencies is applied. Order of definition of the dataset matters. Availability of inputs is checked in that order. Only if input instances of the first dataset is not available, then the input instances of the second dataset will be checked and so on. In case of AND or OR, the second dataset is picked only if first dataset does not meet all the input dependencies first. In case of COMBINE, only the input instances missing on the first dataset are checked for availability on the other datasets in order and then included. coord:dataIn() function can be used to get the comma separated list of evaluated hdfs paths given the name of the conditional operator. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (lines 3171 - 3178) <https://reviews.apache.org/r/48149/#comment201645> Remove this example docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3179) <https://reviews.apache.org/r/48149/#comment201642> Make this also as an example after the other min wait examples. propogate -> propagate. Please run spell check once on the patch diff. Dataset -> dataset docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3198) <https://reviews.apache.org/r/48149/#comment201644> Append the precedence example explanation here. i.e With above expression one can specify the dataset as AorB. Action will start running as soon dataset A or B is available. Dataset "A" has higher precedence over "B" because it is defined first. Oozie will first check for availability of dataset A and only if A is not available, availability of dataset B will be checked. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3216) <https://reviews.apache.org/r/48149/#comment201649> Remove "Above expression means that" docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3222) <https://reviews.apache.org/r/48149/#comment201640> Combine does not work with latest. Please put the data-in definition of A and B in the beginning and say following examples are based on these datasets. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (lines 3238 - 3240) <https://reviews.apache.org/r/48149/#comment201638> Should be moved to the beginning after COMBINE definition under "Additional options:" docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3240) <https://reviews.apache.org/r/48149/#comment201648> instance -> instances. Why wait for all dependant data available if min is specified? docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3248) <https://reviews.apache.org/r/48149/#comment201646> Remove Oozie docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3259) <https://reviews.apache.org/r/48149/#comment201647> Remove Oozie docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3271) <https://reviews.apache.org/r/48149/#comment201650> After the mininum two dependencies are available, processing will wait for additional 10 minutes to include any dependencies that become available during that period. docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3274) <https://reviews.apache.org/r/48149/#comment201641> Remove the 3. There is no other numbering in this section. Move it below the example as comment like others. Each nested operation can be named and passed into the workflow using coord:dataIn() docs/src/site/twiki/CoordinatorFunctionalSpec.twiki (line 3284) <https://reviews.apache.org/r/48149/#comment201564> Formatting - Rohini Palaniswamy On June 1, 2016, 7:50 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48149/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 7:50 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2445 > https://issues.apache.org/jira/browse/OOZIE-2445 > > > Repository: oozie-git > > > Description > ------- > > Doc for - Specifying coordinator input datasets in more logical ways > (OOZIE-1976) > > > Diffs > ----- > > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki > 75b7354a12ae8c255b9d713856b44ec939092c95 > examples/src/main/apps/coord-input-logic/coordinator.xml > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > examples/src/main/apps/coord-input-logic/job.properties > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > examples/src/main/apps/coord-input-logic/workflow.xml > e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 > src/main/assemblies/examples.xml d70c280ec6e189089dcacb57c6f6f340e77bec3b > > Diff: https://reviews.apache.org/r/48149/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
