----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47837/#review142151 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java (line 405) <https://reviews.apache.org/r/47837/#comment207668> This code seems to be for a different issue. Can you update with details on why this change is done both in jira and here? core/src/main/java/org/apache/oozie/lock/MemoryLocks.java (lines 41 - 42) <https://reviews.apache.org/r/47837/#comment207673> Add private final back core/src/main/java/org/apache/oozie/lock/MemoryLocks.java (line 85) <https://reviews.apache.org/r/47837/#comment207672> Unnecessary garbage object creation. If get is null, then do putIfAbsent. core/src/main/java/org/apache/oozie/service/MemoryLocksService.java (line 33) <https://reviews.apache.org/r/47837/#comment207674> protected core/src/main/java/org/apache/oozie/service/ZKLocksService.java (lines 145 - 146) <https://reviews.apache.org/r/47837/#comment207677> If get is null, then putIfAbsent core/src/main/java/org/apache/oozie/service/ZKLocksService.java (lines 169 - 170) <https://reviews.apache.org/r/47837/#comment207684> Add private final back - Rohini Palaniswamy On May 25, 2016, 6:45 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47837/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 6:45 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2501 > https://issues.apache.org/jira/browse/OOZIE-2501 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2501 ZK reentrant lock doesn't work for few cases > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/wf/ActionStartXCommand.java > 2939b604da579adeca399c879425eafab2536b88 > core/src/main/java/org/apache/oozie/lock/MemoryLocks.java > 7d65ac0e24a62086732ec91fc24f89b62469451d > core/src/main/java/org/apache/oozie/service/MemoryLocksService.java > d7c6a89fd47a219b2ec8ea4fe0caf05dc008943b > core/src/main/java/org/apache/oozie/service/ZKLocksService.java > 35fc8a6592b2ba3c5ed4a78b9cc6ed90dd417f40 > core/src/test/java/org/apache/oozie/lock/TestMemoryLocks.java > 61fec19b346748b22df1b58f014c32b1c04c8c1f > core/src/test/java/org/apache/oozie/service/TestZKLocksService.java > 70aa4d7d54c286fec1858a0d0f97f09fff9b4b9f > > Diff: https://reviews.apache.org/r/47837/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
